Remove redundant SP only versions of DIST_GRID and GATH_GRID#223
Remove redundant SP only versions of DIST_GRID and GATH_GRID#223samhatfield wants to merge 1 commit intodevelopfrom
Conversation
7e9fd71 to
554be3c
Compare
554be3c to
34ac42b
Compare
|
I'd like to get this PR merged. As far as I'm aware, the only place these routines were used was in the IFS prototype (and defunct for almost a decade) EnKF. I recently filed a pull request to remove these cases and now there is no instances of @RyadElKhatibMF can you confirm that MétéoFrance does not make any use of @wdeconinck would you favour completely deleting these routines like in this PR, or leaving in the toplevel subroutines with an abort statement? |
|
I confirm I can't see any use of GATH_GRID_32 nor DIST_GRID_32 |
|
I think in first instance an abort, and then that gives some time for some configurations like DestinE not relying on CY50R1, but definitely happy to use recent ectrans GPU developments to catch up without linking errors. |
Sorry, not sure what you mean by that last part? |
|
Sorry @samhatfield I missed your last question before. What I meant is to keep the routines for now but completely empty, except for an abort statement with deprecation message; essentially a dummy. This is just to allow current and older IFS cycles to keep linking with ectrans, even if these routines don't get executed at runtime. |
Resolves #126.
Please wait for my signal before merging this -> this depends on a PR to ifs-source to remove calls to _32 subroutines which is under review.