Skip to content

fix(ci): gate Dependabot auto-merge on CI passing#2

Merged
pnehrer merged 2 commits into
mainfrom
fix/dependabot-auto-merge
Jun 16, 2026
Merged

fix(ci): gate Dependabot auto-merge on CI passing#2
pnehrer merged 2 commits into
mainfrom
fix/dependabot-auto-merge

Conversation

@pnehrer

@pnehrer pnehrer commented Jun 16, 2026

Copy link
Copy Markdown
Member

Problem

The previous workflow used on: pull_request and called gh pr merge --auto --squash. Without branch protection rules requiring status checks, --auto resolves immediately — CI never has a chance to run before the merge lands.

Fix

Switch the trigger to on: workflow_run targeting the Rust CI workflow. The job only runs when that workflow completes with conclusion == 'success', so CI must pass before any merge is attempted.

The workflow_run event carries the head SHA of the triggering PR, which the step uses to look up the open PR and inspect the Dependabot commit message for update types.

Preserved behavior

The 0.x minor bump guard is kept intact: minor-version bumps where the previous version starts with 0. are excluded, consistent with Cargo's convention that a 0.x → 0.y change is potentially breaking.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Line coverage: 18%
Lines covered: 729
Lines missed: 3,347
Total lines: 4,076

@pnehrer pnehrer merged commit 4d33311 into main Jun 16, 2026
2 checks passed
@pnehrer pnehrer deleted the fix/dependabot-auto-merge branch June 16, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant