fix(ci): gate Dependabot auto-merge on CI passing#2
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The previous workflow used
on: pull_requestand calledgh pr merge --auto --squash. Without branch protection rules requiring status checks,--autoresolves immediately — CI never has a chance to run before the merge lands.Fix
Switch the trigger to
on: workflow_runtargeting theRust CIworkflow. The job only runs when that workflow completes withconclusion == 'success', so CI must pass before any merge is attempted.The
workflow_runevent carries the head SHA of the triggering PR, which the step uses to look up the open PR and inspect the Dependabot commit message for update types.Preserved behavior
The 0.x minor bump guard is kept intact: minor-version bumps where the previous version starts with
0.are excluded, consistent with Cargo's convention that a0.x → 0.ychange is potentially breaking.