CMake: fix absolute include install dir#702
Open
nim65s wants to merge 1 commit intoeclipse-zenoh:mainfrom
Open
CMake: fix absolute include install dir#702nim65s wants to merge 1 commit intoeclipse-zenoh:mainfrom
nim65s wants to merge 1 commit intoeclipse-zenoh:mainfrom
Conversation
|
PR missing one of the required labels: {'api-sync', 'new feature', 'breaking-change', 'dependencies', 'enhancement', 'ci', 'documentation', 'internal', 'bug'} |
Users may want to provide absolute paths in `CMAKE_INSTALL_INCLUDEDIR`. When this is the case, we should not prefix it in any way.
|
PR missing one of the required labels: {'new feature', 'bug', 'internal', 'enhancement', 'dependencies', 'documentation', 'breaking-change', 'ci', 'api-sync'} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Users may want to provide absolute paths in
CMAKE_INSTALL_INCLUDEDIR. When this is the case, we should not prefix it in any way.Without this, building https://github.com/gazebosim/gz-transport v15 on nixos currently fail with:
edit: fix relocatable setup