Bravyi-Kitaev#461
Open
danclaudino wants to merge 3 commits into
Open
Conversation
Signed-off-by: Daniel Claudino <6d3@ornl.gov>
|
|
amccaskey
reviewed
Aug 6, 2021
| std::shared_ptr<Observable> | ||
| JW::transform(std::shared_ptr<Observable> Hptr_input) { | ||
|
|
Contributor
There was a problem hiding this comment.
Why did you delete this preprocessing part - could be that the Observable is PySCF or something like that - it would have a fermionic structure, but will not pass the check that it is a FermionOperator.
Contributor
Author
There was a problem hiding this comment.
I think I did this because the algorithms in which we use the transforms have some pre-processing of sorts. More generally, I decided to put it back in case of a new application that doesn't rely on the already implemented algorithms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
FermionOperator::normalize()andPauliOperator::normalize()