-
Notifications
You must be signed in to change notification settings - Fork 27
restrict tagging in bazel_registry #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
restrict tagging in bazel_registry #107
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/otterdog validate info |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces tag protection functionality to the bazel_registry repository as a test case for restricting tagging operations to specific committers. The implementation adds a reusable block_tagging function that creates GitHub repository rulesets to prevent unauthorized tag creation, deletion, and updates.
Key changes:
- Added
block_tagginghelper function to create tag protection rulesets with configurable patterns and bypass actors - Applied tag protection to
bazel_registryrepo restricting tag operations to infrastructure maintainers - Enhanced code documentation with comments explaining review rule configurations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/otterdog validate |
This comment has been minimized.
This comment has been minimized.
|
Thank you for raising a pull request to update the configuration of your GitHub organization. The following conditions need to fulfilled for auto-merging to be available:
Otterdog commands and optionsYou can trigger otterdog actions by commenting on this PR:
|
|
The author (AlexanderLanin) of this PR is associated with this organization in the role of Additionally, AlexanderLanin is a member of the following teams: |
This comment has been minimized.
This comment has been minimized.
cb76baa to
a130e2d
Compare
This comment has been minimized.
This comment has been minimized.
|
rebased |
This comment has been minimized.
This comment has been minimized.
a130e2d to
229c777
Compare
|
rebased again; pypi environment was introduced in #104 |
|
Please find below the validation of the requested configuration changes: Diff for 229c777Project automotive.score[github_id=eclipse-score]
there have been 29 validation infos, enable verbose output to display them.
+ add repo_ruleset[name="tags-protection", repository=bazel_registry] {
+ allows_creations = false
+ allows_deletions = false
+ allows_force_pushes = false
+ allows_updates = false
+ bypass_actors = [
+ "@eclipse-score-bot"
+ "@eclipse-score/infrastructure-maintainers"
+ ],
+ enforcement = "active"
+ exclude_refs = []
+ include_refs = [
+ "refs/tags/*"
+ ],
+ name = "tags-protection"
+ requires_commit_signatures = false
+ requires_deployments = false
+ requires_linear_history = false
+ target = "tag"
+ }
Plan: 1 to add, 0 to change, 0 to delete. |
|
Warning The current configuration is out-of-sync with the live settings: Diff to live settingsProject automotive.score[github_id=eclipse-score]
there have been 29 validation infos, enable verbose output to display them.
! environment[name="pypi", repository=dash-license-scan] {
! reviewers = [
+ "@eclipse-score/infrastructure-maintainers"
! ]
! }
! environment[name="pypi", repository=tools] {
! reviewers = [
+ "@eclipse-score/infrastructure-maintainers"
! ]
! }
Plan: 0 to add, 2 to change, 0 to delete.Important The current configuration needs to be updated to reflect the live settings otherwise they would be overwritten when this PR gets merged. cc @eclipse-score/eclipsefdn-security cc @eclipse-score/eclipsefdn-releng |
|
@mbarbero I cannot approve the run on https://github.com/eclipse-score/dash-license-scan/deployments/pypi Could you check if reviewers were set correctly by otterdog? I guess this observation would match the diff to live settings warning?! |
Attempt to restrict tagging to a subset of committers.
Using
bazel_registryhere, because we don't use tags in that repo. So we can use it for testing this restriction.