Honor expression context when creating Watches #2311
+54
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SougandhS
force-pushed
the
ImproveWatchExp
branch
from
9cd2c8b to
258d31a
Compare
Contributor
SougandhS
force-pushed
the
ImproveWatchExp
branch
2 times, most recently
from
9f1d82f to
94c201a
Compare
SougandhS
force-pushed
the
ImproveWatchExp
branch
2 times, most recently
from
d6d6fed to
691bfc1
Compare
When selecting a field under an object, both the Watch command and Drag & Drop previously created a non-contextual expression using only the field name, which caused evaluation failures. This fix ensures that both Watch and Drag & Drop now generate proper context-aware expressions such as myobj.myfield instead of just the field name. Fixes : https://bugs.eclipse.org/bugs/show_bug.cgi?id=321289
SougandhS
force-pushed
the
ImproveWatchExp
branch
from
691bfc1 to
ed20f18
Compare
Contributor
Author
|
Hi @merks, could you please check this change when you get a moment ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting a field under an object, both the Watch command and Drag & Drop previously created a non-contextual expression using only the field name, which causes evaluation failures. This fix ensures that both Watch and Drag & Drop now generate proper context-aware expressions such as myobj.myfield instead of just the field name.
Fixes : https://bugs.eclipse.org/bugs/show_bug.cgi?id=321289
Before [Watch by context and by drag-drop] :
Before.mp4
After [Watch by context and by drag-drop] :
After.mp4