Skip to content

Improve Create New checkbox handling in CreateWorkspace page object#23770

Merged
dmytro-ndp merged 4 commits intoeclipse-che:mainfrom
SkorikSergey:improve-create-new-checkbox-handling
Mar 13, 2026
Merged

Improve Create New checkbox handling in CreateWorkspace page object#23770
dmytro-ndp merged 4 commits intoeclipse-che:mainfrom
SkorikSergey:improve-create-new-checkbox-handling

Conversation

@SkorikSergey
Copy link
Contributor

What does this PR do?

The "Create New" checkbox in the CreateWorkspace page had several reliability issues:

  1. Checkbox not visible: The checkbox is located at the bottom of the page and sometimes not visible, causing click failures
  2. State change timing: When entering a Git repository URL, the checkbox automatically changes state, but this takes variable time

Solution

  • Added waitForCheckboxState() method - polls every 500ms until checkbox reaches expected state (checked/unchecked), with configurable timeout
  • Added scroll before click - both clickOnCreateNewWorkspaceCheckbox() and setCreateNewWorkspaceCheckbox() now use scrollToAndClick() to ensure the checkbox is visible before clicking
  • Used polling in setCreateNewWorkspaceCheckbox() - after clicking, waits for checkbox to reach the expected state using the new polling method

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-10403

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmytro-ndp dmytro-ndp merged commit b9af639 into eclipse-che:main Mar 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants