Fix Git branch selection in CreateWorkspace pageobject from available branches list

[SkorikSergey]

What does this PR do?

Now it is possible to select branch from branches list after putting repository url to 'Git repo URL *' field. It will fix FactoryWithGitRepoOptions e2e test failing on DS 3.27.0.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-10367

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix or new feature
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[artaleks9]

Looks good to merge.
One small note: if possible, using CSS instead of XPath is considered good practice.
For example:

By.xpath('//input[@type="search"] -> By.css('input[type="search"]')
By.xpath(`//li[@id="${branchName}"] -> By.css(`li[id="${branchName}"]`)

[SkorikSergey]

Looks good to merge. One small note: if possible, using CSS instead of XPath is considered good practice. For example:

By.xpath('//input[@type="search"] -> By.css('input[type="search"]')
By.xpath(`//li[@id="${branchName}"] -> By.css(`li[id="${branchName}"]`)

Thank you. Locators updated to use By.css

[dmytro-ndp]

fix typo:

Suggested change

	await this.driverHelper.waitVisibility(CreateWorkspace.GIT_BRANCH_SEACH_FIELD, timeout);
	await this.driverHelper.waitVisibility(CreateWorkspace.GIT_BRANCH_SEARCH_FIELD, timeout);

[dmytro-ndp]

fix typo:

Suggested change

	private static readonly GIT_BRANCH_SEACH_FIELD: By = By.css('input[type="search"]');
	private static readonly GIT_BRANCH_SEARCH_FIELD: By = By.css('input[type="search"]');

[dmytro-ndp]

fix typo:

Suggested change

	await this.driverHelper.type(CreateWorkspace.GIT_BRANCH_SEACH_FIELD, Key.chord(branchName), timeout);
	await this.driverHelper.type(CreateWorkspace.GIT_BRANCH_SEARCH_FIELD, Key.chord(branchName), timeout);

[dmytro-ndp]

li[id="${branchName}"] is quite broad. It matches any <li> on the entire page with that ID, not just ones inside the branch dropdown. If there were another <li id="main"> somewhere else in the DOM, it could match the wrong element.

IMHO the better correct locator is:

return By.css(`li[id="${branchName}"] button.pf-c-select__menu-item`);

[dmytro-ndp]

LGTM