Skip to content

fix: use random UUID as private key alias for participant manifests #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paullatzelsperger merged 2 commits into from
May 26, 2026
Merged

fix: use random UUID as private key alias for participant manifests #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da8d6ab
fix: use random UUID as private key alias for participant manifests
paullatzelsperger May 26, 2026
d81eb0c
fix vault container start
paullatzelsperger May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions agent/common/identityhub/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"strings"

commonvault "github.com/eclipse-cfm/cfm/agent/common/vault"
"github.com/google/uuid"
)

const (
Expand Down Expand Up @@ -85,7 +86,7 @@ func NewParticipantManifest(
IsActive: true,
KeyGeneratorParameters: KeyGeneratorParameters{
KeyID: DefaultKeyID,
PrivateKeyAlias: DefaultKeyID,
PrivateKeyAlias: uuid.NewString(),
KeyAlgorithm: DefaultAlgorithm,
Curve: DefaultCurve,
},
Expand All @@ -103,9 +104,7 @@ func NewParticipantManifest(
if !strings.HasPrefix(sanitizedKeyID, "#") {
sanitizedKeyID = "#" + sanitizedKeyID
}
sanitizedKeyID = did + sanitizedKeyID
manifest.KeyGeneratorParameters.KeyID = sanitizedKeyID
manifest.KeyGeneratorParameters.PrivateKeyAlias = sanitizedKeyID
manifest.KeyGeneratorParameters.KeyID = did + sanitizedKeyID
}

return manifest
Expand Down
4 changes: 3 additions & 1 deletion agent/common/identityhub/types_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"encoding/json"
"testing"

"github.com/google/uuid"
"github.com/stretchr/testify/require"
)

Expand All @@ -28,7 +29,8 @@ func TestNewParticipantManifest_WithDefaults(t *testing.T) {
require.Equal(t, manifest.ProtocolServiceID, "test-id-dsp")
require.Equal(t, manifest.IsActive, true)
require.Equal(t, manifest.KeyGeneratorParameters.KeyID, "did:web:foo#"+DefaultKeyID)
require.Equal(t, manifest.KeyGeneratorParameters.PrivateKeyAlias, "did:web:foo#"+DefaultKeyID)
_, err := uuid.Parse(manifest.KeyGeneratorParameters.PrivateKeyAlias)
require.NoError(t, err)
require.Equal(t, manifest.VaultConfig.SecretPath, "v1/participants")
require.Equal(t, manifest.VaultConfig.FolderPath, "test-id/identityhub")
}
Expand Down
4 changes: 4 additions & 0 deletions assembly/vault/fixtures.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
"github.com/eclipse-cfm/cfm/assembly/serviceapi"
"github.com/eclipse-cfm/cfm/common/system"
"github.com/google/uuid"
"github.com/moby/moby/api/types/container"
"github.com/stretchr/testify/require"
"github.com/testcontainers/testcontainers-go"
"github.com/testcontainers/testcontainers-go/network"
Expand Down Expand Up @@ -66,6 +67,9 @@ func StartVaultContainer(ctx context.Context, networkName string) (*ContainerRes
ExposedPorts: []string{vaultPort},
Networks: []string{networkName},
Name: name,
HostConfigModifier: func(hc *container.HostConfig) {
hc.CapAdd = append(hc.CapAdd, "IPC_LOCK")
},
Env: map[string]string{
"VAULT_DEV_ROOT_TOKEN_ID": vaultRootToken,
"SKIP_SETCAP": "true", // this is required to run as non-root user in some environments, such as M1 macs
Expand Down