Skip to content

CSV customization#2

Open
keichan34 wants to merge 4 commits into
ecl1pse:masterfrom
keichan34:csv-customization
Open

CSV customization#2
keichan34 wants to merge 4 commits into
ecl1pse:masterfrom
keichan34:csv-customization

Conversation

@keichan34
Copy link
Copy Markdown

I've made a couple modifications to customize the CSV output in a Spree project that I've been working on.

  • Custom output encoding (Apps like Excel don't like UTF-8 😞 )
  • Default options to be passed to CSV
  • The option to make a proc generate the CSV file
  • Appropriate suggested filename for CSV download

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling dddd302 on keichan34:csv-customization into 0f39925 on ecl1pse:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 348b7f2 on keichan34:csv-customization into 0f39925 on ecl1pse:master.

@ecl1pse
Copy link
Copy Markdown
Owner

ecl1pse commented Aug 29, 2013

Thanks so much for the pull request.

Can you add any additional tests or do you not think any are needed?

@keichan34
Copy link
Copy Markdown
Author

I'll work on the test as soon as I can!

I think some unit tests on the decorators could be useful too

@ecl1pse
Copy link
Copy Markdown
Owner

ecl1pse commented Sep 4, 2013

Any updates?

@ecl1pse
Copy link
Copy Markdown
Owner

ecl1pse commented Sep 9, 2013

@keichan34 you around?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants