Cli subcommands add interactive by Fojdjebu · Pull Request #90 · ebzych/amphimixis

Fojdjebu · 2026-04-10T04:10:26Z

Refactor CLI: commands.py into separate modules per subcommand, making it easier for contributors to add new commands
Replace flag‑based (amixis --analyze, --build, etc.) with proper subcommands (amixis analyze, amixis build, etc.)
Add interactive commands to create configuration files via editor: add input and add toolchain
Improve help formatting
Add run subcommand: introduced amixis run /path as the canonical way to run the full pipeline (analyze → build → profile), replacing the previous syntax

KirillSmirnov · 2026-04-17T14:58:10Z

Meow?

ebzych

enjoy)))

…g toolchain and input

…commands

…ctions run_full_pipeline() and parse_full_pipeline_args(), simplify amixis.py main()

…ler functions,

…hain constructor

…ror handling

…nd input

…nput

…content

…mmand clean

ebzych reviewed Apr 10, 2026

View reviewed changes

Comment thread docs/usage_guide.md Outdated

ebzych reviewed Apr 10, 2026

View reviewed changes

Comment thread amphimixis/cli/templates.py

ebzych reviewed Apr 10, 2026

View reviewed changes

Comment thread docs/usage_guide.md Outdated

dabordukov requested changes Apr 10, 2026

View reviewed changes

Comment thread amixis.py Outdated

Comment thread amixis.py Outdated

Comment thread amixis.py Outdated

Comment thread amixis.py Outdated

Comment thread amixis.py Outdated

Comment thread amphimixis/cli/utils.py Outdated

dabordukov requested changes Apr 10, 2026

View reviewed changes

Comment thread amphimixis/cli/commands/add/toolchain.py Outdated

dabordukov requested changes Apr 10, 2026

View reviewed changes

Fojdjebu requested review from IMBIGFISH4, dabordukov and ebzych April 16, 2026 11:21

dabordukov requested changes Apr 16, 2026

View reviewed changes

Comment thread amphimixis/cli/commands/add/input.py Outdated

Comment thread tests/integration/test_e2e_local.py Outdated

Comment thread amphimixis/cli/utils.py

Comment thread amphimixis/cli/templates.py Outdated

Comment thread amphimixis/cli/parser.py Outdated

dabordukov requested changes Apr 16, 2026

View reviewed changes

Comment thread amphimixis/cli/templates.py Outdated

Comment thread amphimixis/cli/commands/clean.py Outdated

dabordukov requested changes Apr 16, 2026

View reviewed changes

Comment thread amphimixis/cli/commands/add/toolchain.py Outdated

dabordukov requested changes Apr 16, 2026

View reviewed changes

Comment thread amphimixis/cli/utils.py Outdated

dabordukov requested changes Apr 17, 2026

View reviewed changes

Comment thread amphimixis/cli/commands/add/input.py Outdated

Comment thread amphimixis/cli/commands/add/input.py Outdated

dabordukov requested changes Apr 17, 2026

View reviewed changes

Comment thread amphimixis/cli/commands/add/input.py Outdated

dabordukov previously approved these changes Apr 17, 2026

View reviewed changes

ebzych removed the request for review from IMBIGFISH4 April 17, 2026 16:27

ebzych requested changes Apr 17, 2026

View reviewed changes

Fojdjebu added 11 commits April 18, 2026 19:33

refactor(cli):update CLI command structure, add subcommands for addin…

f764525

…g toolchain and input

refactor(cli): remove global path and config arguments

bc14e5f

refactor(cli): add interactive 'add input/toolchain', refactor to sub…

a37c4c8

…commands

refactor(cli): save toolchains to global config, update add templates

76e5cd4

refactor(cli): extract templates to separate module, add pipeline fun…

8b669e5

…ctions run_full_pipeline() and parse_full_pipeline_args(), simplify amixis.py main()

refactor(cli): refactor run_add_input and run_add_toolchain with smal…

99e3521

…ler functions,

refactor(cli): add DEFAULT_CONFIG_PATH to constants.py

1e065d6

refactor(cli): modularize commands and improve help system

5d9a013

fix: remove unused import

83c8f7c

refactor(cli): remove unused elif

cb9a49c

fix(cli): fix cyclic imports and duplicate code

ef14396

Fojdjebu added 8 commits April 19, 2026 17:30

docs: improve docstrings, update examples and fix templates

f6a4dc8

fix(tests): remove unnecessary flag

d726b94

fix(configurator): convert toolchain name to string and pass to Toolc…

5f3587f

…hain constructor

refactor(cli): add field validators, auto-create platform, improve er…

a7b6922

…ror handling

refactor(cli): simplify editor interaction and validation in subcomma…

013946d

…nd input

style(cli): use absolute imports in __init__.py

66e13c6

docs: update docstrings to reST style with inline types

83a754f

refactor(cli): remove unused current_content variable in subcommand i…

d89dcc9

…nput

Fojdjebu dismissed dabordukov’s stale review via d89dcc9 April 19, 2026 16:46

Fojdjebu force-pushed the cli-subcommands-add-interactive branch from beeb923 to d89dcc9 Compare April 19, 2026 16:46

Fojdjebu requested review from IMBIGFISH4, dabordukov and ebzych April 19, 2026 16:48

dabordukov requested changes Apr 19, 2026

View reviewed changes

Comment thread amphimixis/cli/utils.py Outdated

Comment thread amphimixis/cli/utils.py Outdated

Fojdjebu added 3 commits April 19, 2026 21:30

fix(cli): remove temp file deletion from launch_editor and read_file_…

bc23df5

…content

fix(validator): reset error counter on each validate call

832a72d

refactor(cli): reorder functions

8eb1533

ebzych requested changes Apr 19, 2026

View reviewed changes

Comment thread amphimixis/cli/commands/clean.py Outdated

Comment thread amphimixis/cli/commands/add/input.py Outdated

Fojdjebu added 2 commits April 19, 2026 23:43

refactor(cli): replace get_content_with_editor with launch_editor

f2b72d4

fix(cli): simplify error handling when builds list not found in subco…

9b2eb03

…mmand clean

IMBIGFISH4 requested changes Apr 19, 2026

View reviewed changes

Comment thread amphimixis/cli/commands/run.py Outdated

fix(cli): improve user prompts and remove redundant messages

a7fb5d6

IMBIGFISH4 previously approved these changes Apr 19, 2026

View reviewed changes

fix(cli): remove unused flag --version

2a2008f

Fojdjebu dismissed IMBIGFISH4’s stale review via 2a2008f April 20, 2026 00:59

dabordukov approved these changes Apr 20, 2026

View reviewed changes

dabordukov requested a review from ebzych April 20, 2026 01:04

IMBIGFISH4 approved these changes Apr 20, 2026

View reviewed changes

ebzych approved these changes Apr 20, 2026

View reviewed changes

ebzych merged commit 1ed5a8b into ebzych:main Apr 20, 2026
3 checks passed

Conversation

Fojdjebu commented Apr 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KirillSmirnov commented Apr 17, 2026

Uh oh!

ebzych left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants