Skip to content

Add support for deleting messages from ChatTabs and trigger associate… #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheBjoRedCraft wants to merge 2 commits into
base: version/1.21.11
Choose a base branch
from
Open

Add support for deleting messages from ChatTabs and trigger associate… #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79261e5
Add support for deleting messages from ChatTabs and trigger associate…
TheBjoRedCraft Feb 28, 2026
c499a5b
bump: update mod_version to 2.7.2
TheBjoRedCraft Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions common/src/main/java/com/ebicep/chatplus/mixin/MixinChatComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
import net.minecraft.network.chat.MessageSignature;
import net.minecraft.util.profiling.Profiler;
import net.minecraft.util.profiling.ProfilerFiller;
import org.jspecify.annotations.Nullable;
import org.slf4j.Logger;
import org.spongepowered.asm.mixin.Final;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow;
Expand All @@ -36,6 +38,10 @@ public class MixinChatComponent {
@Shadow
Minecraft minecraft;

@Shadow
@Final
private static Logger LOGGER;

@Inject(method = "render(Lnet/minecraft/client/gui/GuiGraphics;Lnet/minecraft/client/gui/Font;IIIZZ)V", at = @At("HEAD"), cancellable = true)
public void render(GuiGraphics guiGraphics, Font font, int i, int j, int k, boolean bl, boolean bl2, CallbackInfo ci) {
if (!ChatPlus.INSTANCE.isEnabled() || (Config.INSTANCE.getValues().getShowVanillaWhenUnfocused() && !ChatManager.INSTANCE.isChatFocused())) {
Expand Down Expand Up @@ -110,5 +116,14 @@ public void addMessage(
EventBus.INSTANCE.post(SkipNewMessageEvent.class, messageEvent);
}
}
@Inject(method = "deleteMessage(Lnet/minecraft/network/chat/MessageSignature;)V", at = @At("RETURN"))
public void deleteMessage(MessageSignature messageSignature, CallbackInfo ci) {
if (!ChatPlus.INSTANCE.isEnabled()) {
return;
}

for (ChatTab chatTab : ChatManager.INSTANCE.getGlobalSortedTabs()) {
chatTab.deleteMessage(messageSignature);
}
}
}
22 changes: 22 additions & 0 deletions common/src/main/kotlin/com/ebicep/chatplus/features/chattabs/ChatTab.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,28 @@ class ChatTab {
return added
}

fun deleteMessage(signature: MessageSignature) {
val messageIndex = messages.indexOfFirst { it.guiMessage.signature == signature }
if (messageIndex == -1) return

val message = messages.removeAt(messageIndex)
EventBus.post(ChatTabRemoveMessageEvent(chatWindow, this, message))

displayedMessages.removeIf {
val match = it.linkedMessage === message
if (match) {
EventBus.post(ChatTabRemoveDisplayMessageEvent(chatWindow, this, it))
}
match
}

unfilteredDisplayedMessages.removeIf {
it.linkedMessage === message
}

refreshDisplayMessages()
}

fun clear() {
messages = ArrayList()
displayedMessages = ArrayList()
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ supported_minecraft_version=1.21.11
enabled_platforms=fabric,neoforge
archives_base_name=chatplus
mod_id=chatplus
mod_version=2.7.1
mod_version=2.7.2
mod_name=ChatPlus
mod_description=Minecraft chat improved.
mod_authors=ebicep
Expand Down