Skip to content

Conversation

@AndrewSazonov
Copy link
Member

No description provided.

@AndrewSazonov AndrewSazonov requested a review from Copilot January 5, 2026 11:22
@AndrewSazonov AndrewSazonov added the [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH) label Jan 5, 2026
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.93%. Comparing base (883c384) to head (efd81a0).
⚠️ Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #121      +/-   ##
===========================================
+ Coverage    82.26%   82.93%   +0.67%     
===========================================
  Files           88       89       +1     
  Lines         5451     5461      +10     
  Branches       454      453       -1     
===========================================
+ Hits          4484     4529      +45     
+ Misses         802      761      -41     
- Partials       165      171       +6     
Flag Coverage Δ
integration 68.52% <100.00%> (-1.43%) ⬇️
unittests 73.48% <100.00%> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request vendors the jupyter-dark-detect package into the codebase to simplify conda-forge packaging by eliminating an external dependency. The PR also updates copyright years from 2025 to 2026 across all source files and adds a custom wrapper module with a modified detection order optimized for EasyDiffraction's use case.

Key changes:

  • Vendors jupyter-dark-detect package under src/easydiffraction/utils/_vendored/jupyter_dark_detect/
  • Adds custom theme_detect wrapper module with detection order: JupyterLab settings → VS Code settings → JavaScript DOM → System preferences
  • Updates import from jupyter_dark_detect to the vendored easydiffraction.utils._vendored.theme_detect in production code
  • Removes jupyter_dark_detect dependency from pyproject.toml while keeping darkdetect for system-level detection

Reviewed changes

Copilot reviewed 208 out of 208 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/easydiffraction/utils/_vendored/jupyter_dark_detect/* Vendored copy of upstream jupyter-dark-detect package with detector logic
src/easydiffraction/utils/_vendored/theme_detect.py Custom wrapper implementing modified detection priority order
src/easydiffraction/utils/_vendored/__init__.py Documentation for vendored code with update instructions
src/easydiffraction/display/tablers/base.py Updated import to use vendored theme_detect module
tests/unit/easydiffraction/utils/test_theme_detect.py Comprehensive test suite for vendored theme detection functionality
tools/update_spdx.py Added exclusion pattern for vendored code to skip SPDX updates
pyproject.toml Removed jupyter_dark_detect dependency and added ruff lint exceptions for vendored code
tmp/display3.py Example/temporary file showing usage of vendored theme_detect
All other files Copyright year updated from 2025 to 2026

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AndrewSazonov AndrewSazonov merged commit 85def95 into develop Jan 5, 2026
22 of 23 checks passed
@AndrewSazonov AndrewSazonov deleted the 120-vendor-in-jupyter_dark_detect branch January 6, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants