Properly track fromId in branch_summary events#3795
Open
CGamesPlay wants to merge 1 commit into
Open
Conversation
Contributor
|
This PR was auto-closed. Only contributors approved with Maintainers review auto-closed issues daily. Issues that do not meet the quality bar in CONTRIBUTING.md will not be reopened or receive a reply. If a maintainer replies See CONTRIBUTING.md. |
CGamesPlay
force-pushed
the
push-uvvwpvnlnnkn
branch
from
7d3d3be to
cefb534
Compare
Author
|
Rebased. This is still relevant. |
CGamesPlay
force-pushed
the
push-uvvwpvnlnnkn
branch
from
cefb534 to
2fc87d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In session.md the doumentation for BranchSummaryEntry says that
parentIdshould be different fromfromId. The docs don't say how they should be different, but it seems clear thatparentIdis the target location in the session history andfromIdis the original leaf that was summarized when the navigation happened.I don't think Pi has ever supported this. It's currently setting
fromId == parentId, always. This small patch gets pi to properly record the truefromIdwhen summarizing branches.I need this for an extension that walks the message history (like the example TODO extension) and should be able to understand when tree navigations happen so that it can properly keep the state from those branches.
Resolves #3796