-
Notifications
You must be signed in to change notification settings - Fork 889
[23929] Allow to send empty payloads in dispose/unregister ops (backport #6217) #6236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mergify
wants to merge
3
commits into
3.3.x
Choose a base branch
from
mergify/bp/3.3.x/pr-6217
base: 3.3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allowing to send empty payloads in dispose/unregister ops Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refactor to keep current execution path for most cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Making readers able to read empty paoload messages Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests for RTPS readers Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix trace logging in topic_instances example, that always showed the same color on dispose Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Make writer write empty payload only if get_payload fails Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Late disposes are not received in history and cause segfault when freed Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix asan problems Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Apply easy suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Apply revision part2 Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update src/cpp/fastdds/publisher/DataWriterImpl.cpp Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> * Replace old signature name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove unnecessary check Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding assert in case that should not happen Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Removing line Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 47bfac0) # Conflicts: # test/unittest/dds/publisher/DataWriterTests.cpp
Contributor
Author
|
Cherry-pick of 47bfac0 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
10 tasks
f105c7e to
686cdd7
Compare
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
686cdd7 to
8109ba9
Compare
cferreiragonz
previously approved these changes
Jan 12, 2026
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
8db57bb to
734e0d9
Compare
Contributor
Author
🧪 CI InsightsHere's what we observed from your CI run for 734e0d9. ❌ Job Failures
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves the handling of dispose and unregister operations when payloads are empty, and enhances test coverage for these scenarios. Until now, it was not possible to send those messages with empty payloads, now it is allowed as long as a valid instance handle is provided.
@Mergifyio backport 3.4.x 3.3.x 3.2.x 2.14.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.mdfile (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #6217 done by [Mergify](https://mergify.com).