Fix entity and user and IDs in profiles to match the int16_t specification #6215
+314
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As pointed out in #2686, the
entityIDanduserDefinedIDfields don't meet the specification ofint16_tfor data reader and data writer XML configuration:This significantly limits the usability of static EDP in larger deployments.
While these changes are to non-public APIs as of version 3.0 according to the versions.md file, it would still be useful to back-port these to at least 2.14.x, which is the current version in use by ROS2's Jazzy LTS release. As these interfaces were considered part of the public API prior to version 3.0, how should this be handled? One option is to keep the previously-defined functions which accept
uint8_tfor the user and entity IDs and mark them as deprecated.@Mergifyio backport 3.3.x 3.2.x 2.14.x 2.10.x
Fixes #2686
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist