Skip to content

Conversation

@thomasmoore-torc
Copy link

Description

As pointed out in #2686, the entityID and userDefinedID fields don't meet the specification of int16_t for data reader and data writer XML configuration:

This significantly limits the usability of static EDP in larger deployments.

While these changes are to non-public APIs as of version 3.0 according to the versions.md file, it would still be useful to back-port these to at least 2.14.x, which is the current version in use by ROS2's Jazzy LTS release. As these interfaces were considered part of the public API prior to version 3.0, how should this be handled? One option is to keep the previously-defined functions which accept uint8_t for the user and entity IDs and mark them as deprecated.

@Mergifyio backport 3.3.x 3.2.x 2.14.x 2.10.x

Fixes #2686

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

…ation

Signed-off-by: Thomas Moore <thomas.moore@torc.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<userId> xml field for EDP is not a uint16_t [14633]

1 participant