feature: Add twap active, order history, fill orders table to the fe#1861
Closed
anmolagrawal345 wants to merge 7 commits intomainfrom
Closed
feature: Add twap active, order history, fill orders table to the fe#1861anmolagrawal345 wants to merge 7 commits intomainfrom
anmolagrawal345 wants to merge 7 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jaredvu
reviewed
Aug 27, 2025
jaredvu
reviewed
Aug 27, 2025
| return calculateOrderHistory(orders); | ||
| }); | ||
|
|
||
| export const selectTWAPOrders = createAppSelector([selectAccountOrders], (orders) => { |
Collaborator
There was a problem hiding this comment.
Is there need for selecting TWAP orders that aren't open?
Collaborator
There was a problem hiding this comment.
can simplify 148 to just filtering TWAP from selectOpenOrders instead
Contributor
There was a problem hiding this comment.
Will eventually have historic TWAP orders so probably will use this selector in a couple of different places
jaredvu
reviewed
Aug 27, 2025
package.json
Outdated
Comment on lines
221
to
222
| "@injectivelabs/sdk-ts": "1.16.10", | ||
| "@injectivelabs/ts-types": "1.16.10" |
jaredvu
reviewed
Aug 27, 2025
src/pages/twap/TWAPTable.tsx
Outdated
| }, | ||
| { | ||
| value: 'OrderHistory', | ||
| label: 'Order History', |
jaredvu
reviewed
Aug 27, 2025
src/pages/twap/TWAPTable.tsx
Outdated
| const tabItems: TabItem<string>[] = [ | ||
| { | ||
| value: 'Active', | ||
| label: 'Active', |
jaredvu
reviewed
Aug 27, 2025
src/pages/twap/TWAPTable.tsx
Outdated
| import { Tabs, type TabItem } from '@/components/Tabs'; | ||
| import { ActiveTWAPTable, ActiveTWAPTableColumnKey } from './ActiveTWAPTable'; | ||
|
|
||
| const tabItems: TabItem<string>[] = [ |
Collaborator
There was a problem hiding this comment.
put in the component w/ useMemo
jaredvu
reviewed
Aug 27, 2025
src/pages/twap/TWAPTable.tsx
Outdated
| }, | ||
| { | ||
| value: 'Fills', | ||
| label: 'Fills', |
jaredvu
reviewed
Aug 27, 2025
src/pages/twap/TWAPTable.tsx
Outdated
| label: 'Order History', | ||
| content: ( | ||
| <div> | ||
| <h1>Order History</h1> |
jaredvu
reviewed
Aug 27, 2025
src/pages/twap/TWAPTable.tsx
Outdated
| label: 'Fills', | ||
| content: ( | ||
| <div> | ||
| <h1>Fills</h1> |
jaredvu
reviewed
Aug 27, 2025
src/pages/twap/TWAPTable.tsx
Outdated
|
|
||
| const tabItems: TabItem<string>[] = [ | ||
| { | ||
| value: 'Active', |
Collaborator
There was a problem hiding this comment.
or at least make it a type
type TWAPTableTabs = 'Active' | 'OrderHistory' | 'Fills';
Collaborator
There was a problem hiding this comment.
and use with the useState('Active')
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
dankim214
changed the title
Contributor
|
Created new branch based of this here #2078 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.