FEAT[DXTA-297]: Create workflow for github installation data provisioning

[stefanskoricdev]

No description provided.

[davidabram]

I think there should be name of the tenant + org id rather than string + time string.

[davidabram]

Not big fan of sync naming.

[davidabram]

I think this code is incredibly complicated, for no good reason.

What I would like to see is to have a potentially single fetch towards github in a single activity, so if something fails you don't need to fetch all the data again.

Here is a better solution.

import (
    "context"

    "golang.org/x/sync/errgroup"
    "github.com/google/go-github/v72/github"
)

type ExtendedMember struct {
    User  *github.User
    Email *string
    Name  *string
}

func GetInstallationTeamMembersWithEmails(
    ctx context.Context,
    members []*github.User,
    client *github.Client,
) ([]ExtendedMember, error) {
    eg, ctx := errgroup.WithContext(ctx)

    results := make([]ExtendedMember, len(members))

    for i, m := range members {
        i, m := i, m
        eg.Go(func() error {
            user, _, err := client.Users.Get(ctx, *m.Login)
            if err != nil {
                return err
            }

            results[i] = ExtendedMember{
                User:  m,
                Email: user.Email,
                Name:  user.Name,
            }
            return nil
        })
    }

    if err := eg.Wait(); err != nil {
        return nil, err
    }

    return results, nil
}

[davidabram]

This is incredibly dangerous pattern.

You need to limit max number of pages that you plan to visit.

[davidabram]

Few cool patterns:

If you re-assign err, you can use:

	defer func() {
		if err != nil {
			_ = tx.Rollback()
		}
	}()

also error handling can be onelined:

var tenantOrgID int64
	const selectTenantOrg = `
		SELECT id
		FROM organizations
		WHERE auth_id = ?`
	if err = tx.QueryRowContext(ctx, selectTenantOrg, authID).
		Scan(&tenantOrgID); err != nil {
		return nil, fmt.Errorf("finding tenant org: %w", err)
	}