Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Solution
Fixes Home menu item not receiving active state on front page in Drupal 10.
Problem: When the front page is set to a node path (e.g., /node/1), the Home menu item (pointing to /) was not marked as active because the path comparison (/node/1 vs /) failed.
Fix: Added a front page check in the menu active trail detection logic. When on the front page, menu items pointing to / are now correctly marked as active, matching the behavior of other menu items.
This ensures consistent navigation styling across all menu items, including Home, when users are on the homepage.
Testing: Verified on Drupal 10.6.2. Works correctly in Drupal 11 (no changes needed there).
Checklist