Fix CSS var() fallback broken for anonymous users Fixes: #762#764
Open
Fix CSS var() fallback broken for anonymous users Fixes: #762#764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Solution
Fixes CSS displacement API variable fallback broken for anonymous users. The Drupal displacement API sets
--drupal-displace-offset-topto an empty string""for anonymous users (notundefined), which breaks CSSvar()fallbacks incalc()expressions. This caused fixed headers to overlap content for anonymous users.Changes:
calc()expressions using--drupal-displace-offset-topinto separate rules for toolbar vs non-toolbar contextsdxpr-theme-header--mobile.scss): Use header height only for anonymous users,calc()with displacement for toolbar usersdxpr-theme-header--top.scss): Use30pxfor anonymous users,calc()with displacement for toolbar usersheader-theme-settings-css.inc): Split into:not(.toolbar-*)rule for anonymous users and separate rules for toolbar classesAnonymous users now get proper body padding without invalid
calc()expressions, while admin users with toolbars continue to use displacement API offsets correctly.Checklist