Handle exception when BQM is passed to DQM sampler#444
Open
Abdullahjavednesar wants to merge 2 commits intodwavesystems:masterfrom
Open
Handle exception when BQM is passed to DQM sampler#444Abdullahjavednesar wants to merge 2 commits intodwavesystems:masterfrom
Abdullahjavednesar wants to merge 2 commits intodwavesystems:masterfrom
Conversation
Author
|
Hi @arcondello, can you please take a look! |
arcondello
reviewed
Mar 1, 2022
Author
|
Addressed both the comments. Thanks for the review! |
Codecov Report
@@ Coverage Diff @@
## master #444 +/- ##
==========================================
- Coverage 90.52% 87.59% -2.94%
==========================================
Files 22 22
Lines 1520 1523 +3
==========================================
- Hits 1376 1334 -42
- Misses 144 189 +45
Continue to review full report at Codecov.
|
Member
|
Hi @Abdullahjavednesar , sorry for the very long delay. Any chance you can rebase this against the current master branch? We can also do it on our side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #375
Before
BinaryQuadraticModel objects when passed to DQM sampler, raised an exception which wasn't informative.
Now (after fix)