Open
Conversation
arcondello
reviewed
Mar 9, 2022
Contributor
JoelPasvolsky
left a comment
JoelPasvolsky
left a comment
There was a problem hiding this comment.
Shouldn't this new feature be release noted?
| raise RuntimeError("A Composite must have at least one child Sampler") | ||
|
|
||
| def innermost_child(self) -> Sampler: | ||
| """Returns the inner-most child sampler""" |
Contributor
There was a problem hiding this comment.
Suggested change
| """Returns the inner-most child sampler""" | |
| """Return the innermost child sampler.""" |
arcondello
reviewed
Mar 9, 2022
Member
arcondello
left a comment
arcondello
left a comment
There was a problem hiding this comment.
Need to add a release note.
Probably should be added to the docs as well, see https://github.com/dwavesystems/dimod/blob/main/docs/reference/sampler_composites/api.rst
|
|
||
| return kwargs | ||
|
|
||
| def innermost_child(self) -> Sampler: |
|
|
||
| def test_composed_sampler(self): | ||
| innermost_child = dimod.ExactSolver() | ||
| sampler = dimod.ClipComposite(dimod.ScaleComposite(innermost_child)) |
Member
There was a problem hiding this comment.
I would use TrackingComposite and StructureComposite since those are staying in dimod through #1127 so the tests stay valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow composite samplers to expose the innermost child sampler, this can be used to gather properties. For example, one can get QPU properties from a composite made of several layers