Refactor file operations out of IO god class#377
Open
gopar wants to merge 2 commits intodwash96:mainfrom
Open
Conversation
Owner
|
Before you get to deep into this, can you start a thread in the discord so we can work out which methods are going to be decomposed into which module files/helper classes? Probably doesn't need to be/shouldn't be figured out for the entirety of it all at once, but io.py is pretty core so I'd prefer to keep eyes on its decomposition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass at breaking out the InputOutput god class. For now, separate out file operations and have InputOutput act as a thing wrapper (facade).
I plan on doing more refactors on this class