Fix multiple linting error in climate.py #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing some lint errors to make it easier to implement #244
Error: pyhilo/device/climate.py:1:1: D400 First line should end with a period
Error: pyhilo/device/climate.py:10:7: D101 Missing docstring in public class
Error: pyhilo/device/climate.py:11:9: ANN204 Missing return type annotation for special method
__init__Error: pyhilo/device/climate.py:11:9: D107 Missing docstring in
__init__Error: pyhilo/device/climate.py:11:54: FA100 Add
from __future__ import annotationsto simplifytyping.UnionError: pyhilo/device/climate.py:12:42: PGH003 Use specific rule codes when ignoring type issues
Error: pyhilo/device/climate.py:16:9: D102 Missing docstring in public method
Error: pyhilo/device/climate.py:20:9: D102 Missing docstring in public method
Error: pyhilo/device/climate.py:24:9: D102 Missing docstring in public method
Error: pyhilo/device/climate.py:32:9: D102 Missing docstring in public method
Error: pyhilo/device/climate.py:40:9: D102 Missing docstring in public method
Error: pyhilo/device/climate.py:44:15: D102 Missing docstring in public method
Error: pyhilo/device/climate.py:48:74: PGH003 Use specific rule codes when ignoring type issues