Skip to content

Optimize JS loading #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liuzc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize JS loading #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 36 additions & 21 deletions duoshuo/WordPress.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,19 +337,28 @@ public function appendScripts(){
static $once = 0;
if ($once ++)
return;
?>
<script type="text/javascript">
var duoshuoQuery = <?php echo json_encode($this->buildQuery());?>;
duoshuoQuery.sso.login += '&redirect_to=' + encodeURIComponent(window.location.href);
duoshuoQuery.sso.logout += '&redirect_to=' + encodeURIComponent(window.location.href);
</script>
<?php

// only load js on single and pages
if(is_single() || is_page()) { ?>

<script type="text/javascript">
var duoshuoQuery = <?php echo json_encode($this->buildQuery());?>;
duoshuoQuery.sso.login += '&redirect_to=' + encodeURIComponent(window.location.href);
duoshuoQuery.sso.logout += '&redirect_to=' + encodeURIComponent(window.location.href);
</script>



<?php
$duoshuo_shortname = 'static';
$url = 'http://' . $duoshuo_shortname . '.' . self::DOMAIN . '/embed.js';
//?pname=wordpress&pver=' . self::VERSION
wp_register_script('duoshuo-embed', $url, array(), null);

//load embed.js before </body>
wp_register_script('duoshuo-embed', $url, array(), null,true);

wp_enqueue_script('duoshuo-embed');
wp_enqueue_script('duoshuo-embed');
}
}

/**
Expand All @@ -361,18 +370,24 @@ public function printScripts(){
if ($scriptsPrinted)
return;

$duoshuo_shortname = 'static';?>
<script type="text/javascript">
var duoshuoQuery = <?php echo json_encode($this->buildQuery());?>;
duoshuoQuery.sso.login += '&redirect_to=' + encodeURIComponent(window.location.href);
duoshuoQuery.sso.logout += '&redirect_to=' + encodeURIComponent(window.location.href);
(function() {
var ds = document.createElement('script'); ds.type = 'text/javascript'; ds.async = true;
ds.charset = 'UTF-8';
ds.src = 'http://<?php echo $duoshuo_shortname;?>.duoshuo.com/embed.js';
(document.getElementsByTagName('head')[0] || document.getElementsByTagName('body')[0]).appendChild(ds);
})();
</script><?php
$duoshuo_shortname = 'static';
if(is_single() || is_page()){

?>
<script type="text/javascript">
var duoshuoQuery = <?php echo json_encode($this->buildQuery());?>;
duoshuoQuery.sso.login += '&redirect_to=' + encodeURIComponent(window.location.href);
duoshuoQuery.sso.logout += '&redirect_to=' + encodeURIComponent(window.location.href);
(function() {
var ds = document.createElement('script'); ds.type = 'text/javascript'; ds.async = true;
ds.charset = 'UTF-8';
ds.src = 'http://<?php echo $duoshuo_shortname;?>.duoshuo.com/embed.js';
(document.getElementsByTagName('head')[0] || document.getElementsByTagName('body')[0]).appendChild(ds);
})();
</script>

<?php
} //end if(is_single() || is_page())
$scriptsPrinted = true;
}

Expand Down