Skip to content

Feature: adding Huff language support to playground code editor.#150

Closed
Saw-mon-and-Natalie wants to merge 1 commit into
duneanalytics:mainfrom
Saw-mon-and-Natalie:huff-support
Closed

Feature: adding Huff language support to playground code editor.#150
Saw-mon-and-Natalie wants to merge 1 commit into
duneanalytics:mainfrom
Saw-mon-and-Natalie:huff-support

Conversation

@Saw-mon-and-Natalie

@Saw-mon-and-Natalie Saw-mon-and-Natalie commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

This PR adds support for Huff language (a low-level EVM language).

  • yarn lint
  • yarn dev functional

@vercel

vercel Bot commented Jun 22, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
evm-codes ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 0:30AM (UTC)

@dorlevi

dorlevi commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

Thanks for the initiative! I know there are few people who would be happy with this addition, let us look at this in the next couple of days.

D

cc: @malexw @peroket

@peroket peroket left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR ;-)

I must admit I am discovering Huff with this PR, and I would love to know how you are planning to use this new feature with evm.codes.

I will also let @malexw to evaluate it technically.

Comment thread package.json
"gray-matter": "^4.0.3",
"highlight.js": "^11.3.1",
"highlightjs-solidity": "^2.0.1",
"huffc": "Saw-mon-and-Natalie/huffc.git#fileless-parser",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anything, why not point to the original repo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original repo only compiles files and not the content as strings. It also misses declaration files for typescript.

Once those has been added/modified in the original repo, we can change this to huffc.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created a PR for huffc to include the required changes:
feat: Allow parsing/compiling of content only data ...

Once that PR is reviewed and merged, we can update this dependency.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great thanks :-)

@peroket peroket requested a review from malexw June 22, 2022 08:12
@Saw-mon-and-Natalie

Copy link
Copy Markdown
Contributor Author

Thank you for the PR ;-)

I must admit I am discovering Huff with this PR, and I would love to know how you are planning to use this new feature with evm.codes.

I will also let @malexw to evaluate it technically.

@peroket , Huff like other low-level languages (YUL) allows more direct access to EVM opcodes which can be used to optimize for gas consumption. It also includes some higher-level syntax like macros which allows writing huff programs more efficiently.

Adding support for this language to evm.codes would be a great resource for teaching how to use the language and also to onboard new developers.

@dorlevi

dorlevi commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

@Saw-mon-and-Natalie : any news on getting huff-language/huffc#40 in ? (we would like to merge this change but prefer to do so after this is in and the dependency is changed)

@Saw-mon-and-Natalie

Copy link
Copy Markdown
Contributor Author

@dorlevi amazing. I'll ping the team Huff.

@dorlevi

dorlevi commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

Sure thing, hope you understand why we want to wait for that to get resolved, and thanks again for contributing.

@dorlevi

dorlevi commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

@Saw-mon-and-Natalie Any news on merging the huf change?

@Saw-mon-and-Natalie

Saw-mon-and-Natalie commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@Saw-mon-and-Natalie Any news on merging the huf change?

Hi @dorlevi 👋🏽,

My PR was never reviewed on the huffc repo and the repo is now archived. In order to use the new implementation in Rust huff-rs, We/I would need to submit a new PR to the new repo to add a wasm target.

@peroket

peroket commented Jul 13, 2022

Copy link
Copy Markdown

@Saw-mon-and-Natalie Any news on merging the huf change?

Hi @dorlevi 👋🏽,

My PR was never reviewed on the huffc repo and the repo is now archived. In order to use the new implementation in Rust huff-rs, We/I would need to submit a new PR to the new repo to add a wasm target.

Thank you for your anwser. Are you going to update your PR with the new one? We can't add a dependency if the repo is not going to be maintained unfortunately.

@ncitron

ncitron commented Jul 20, 2022

Copy link
Copy Markdown

I've actually been working on wasm bindings for the huff compiler. Once we've got them working I'd be happy to submit a PR if you don't mind @Saw-mon-and-Natalie?

@Saw-mon-and-Natalie

Copy link
Copy Markdown
Contributor Author

I've actually been working on wasm bindings for the huff compiler. Once we've got them working I'd be happy to submit a PR if you don't mind @Saw-mon-and-Natalie?

@ncitron LFG ☺️

@dorlevi

dorlevi commented Sep 20, 2022

Copy link
Copy Markdown
Contributor

@Saw-mon-and-Natalie and @ncitron, I'm just doing some housekeeping and wanted to check in on this.

@peroket

peroket commented May 15, 2023

Copy link
Copy Markdown

Since there was no update on this in a long while, I'm closing the PR, but we would be happy to get that change if you have some time :-)

@peroket peroket closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants