[8.x] Fix checkout form test to properly resolve nested tags#1272
Merged
Conversation
The test was directly calling `$this->tag->index()` on a manually instantiated
CheckoutTags class, which doesn't resolve nested Antlers tags like `{{ sc:gateways }}`.
Updated the test to use the `tag()` helper function which properly parses
Antlers templates through Statamic's `Parse::template()` method.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the
can output checkout formtest was failing because nested Antlers tags weren't being resolved.This was happening because the test was directly instantiating
CheckoutTagsand callingindex()on it with content containing{{ sc:gateways }}. When tags are called directly like this (outside of Statamic's normal parsing pipeline), nested tags aren't resolved.This PR fixes it by using the
tag()helper function which properly parses Antlers templates through Statamic'sParse::template()method, ensuring all nested tags are resolved correctly.