Skip to content

Cart#7

Open
potfur wants to merge 8 commits intodumplie:masterfrom
potfur:cart
Open

Cart#7
potfur wants to merge 8 commits intodumplie:masterfrom
potfur:cart

Conversation

@potfur
Copy link
Copy Markdown
Member

@potfur potfur commented Dec 18, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
License MIT

@potfur potfur force-pushed the cart branch 3 times, most recently from 08719a1 to edd13a0 Compare June 25, 2017 10:57
@norberttech
Copy link
Copy Markdown
Contributor

any ideas why tests are failing?

@potfur
Copy link
Copy Markdown
Member Author

potfur commented Jul 6, 2017

It took me a while to figure out what is happening.
Short story is, that Doctrine v2.5 before doing anything (eg. before creating DB), tries to detect database platform and it is done by using database name. Since there is no DB it flops on its face.
More info here: doctrine/dbal#2671

AFAIK it is not released yet.
So we can wait until it is, or I'll try to create DB from travis.

I'd like also to add to travis matrix cases to run postgresql with --prefer-lowest and mysql without.

@norberttech
Copy link
Copy Markdown
Contributor

we might want to try create a db before running tests, 👍 for matrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants