Closed
Conversation
Contributor
|
FWIW one of the goals of this crate is to compile as fast as possible, so mind taking some measurements of that for both before/after this change? (build time afterwards including that of rustc_lexer |
Author
|
Very unscientific test: So it looks like the removal of |
Author
|
Whoops, just realized I missed a (measurements done with |
Author
|
Second test (with |
dtolnay
reviewed
Oct 16, 2024
Owner
dtolnay
left a comment
There was a problem hiding this comment.
I think I would prefer to stick with this crate's own lexer for now.
Thanks anyway for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the fallback parser to use
rustc_lexer. WIP proof of concept currently.Closes #201, closes #126, impacts #55, #5.
Failing tests:
' staticasLiteral { lit: ' static, span: bytes(1..9) })