Migrate from Javascript to Typescript by Warchant · Pull Request #3 · dstucrypt/gost89

Warchant · 2020-07-04T15:58:20Z

Migrate all JS to TS
Add CI on github actions with node10 and node12 builds
Add gts: includes eslint (static code analyzer), prettier (unified code formatting), typescript configs
Mocha -> Jest

One of goals is to NOT break API for existing JS users, and at the same time add TS declarations, so TS users can benefit from TypeScript.

Existing users should verify that JS API has not been changed.

Warchant · 2020-07-04T16:03:48Z

CI пройшов: https://github.com/Warchant/gost89/actions/runs/157607745

src/hash.ts

muromec · 2020-07-04T16:39:14Z

src/hash.ts

+  const ctx = new Hash();
+  ctx.update(data);
+  if (ret === undefined) {
+    ret = Buffer.alloc(32);


This one (and Hash.mem) was Uint8Array originally, which is what Buffer extends, so I guess this is fine.

package.json

.github/workflows/ci.yml

Warchant · 2020-07-04T18:53:28Z

@muromec TravisCI is green https://www.travis-ci.org/github/dstucrypt/gost89/builds/704977798

src/gost89.ts

Warchant · 2020-07-16T15:45:54Z

Any news?

muromec · 2020-07-16T16:17:14Z

I'm a bit busy with things, but this is not forgotten and would be merged.

Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.12.2 to 6.12.6. - [Release notes](https://github.com/ajv-validator/ajv/releases) - [Commits](ajv-validator/ajv@v6.12.2...v6.12.6) --- updated-dependencies: - dependency-name: ajv dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/ljharb/qs/releases) - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.5.2...v6.5.3) --- updated-dependencies: - dependency-name: qs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [json5](https://github.com/json5/json5) from 2.1.3 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.1.3...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Removes [cacheable-request](https://github.com/jaredwray/cacheable-request). It's no longer used after updating ancestor dependency [gts](https://github.com/google/gts). These dependencies need to be updated together. Removes `cacheable-request` Updates `gts` from 2.0.2 to 3.1.1 - [Release notes](https://github.com/google/gts/releases) - [Changelog](https://github.com/google/gts/blob/main/CHANGELOG.md) - [Commits](https://github.com/google/gts/commits) --- updated-dependencies: - dependency-name: cacheable-request dependency-type: indirect - dependency-name: gts dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8. - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.5...v1.2.8) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…-1.2.8 Bump minimist from 1.2.5 to 1.2.8

…-request-and-gts--removed Bump cacheable-request and gts

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.21) --- updated-dependencies: - dependency-name: lodash dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 5.0.0 to 5.0.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v5.0.0...v5.0.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…ex-5.0.1 Bump ansi-regex from 5.0.0 to 5.0.1

Bump ajv from 6.12.2 to 6.12.6

…-3.1.2

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.10.4 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…averse-7.23.2

….17.21

…i-component-0.2.2

Warchant added 8 commits July 4, 2020 18:15

Port js -> ts

390e85d

Ignore build dir from gts check

0e9f72f

Fix

589c0cd

Use npm instead of yarn

cd461d0

Update README.md

191764b

Move files to root dir

18ec03e

Fix gts check

5ac37b2

Set fail-fast: false

82c49c0

muromec reviewed Jul 4, 2020

View reviewed changes

package.json Show resolved Hide resolved

.github/workflows/ci.yml Outdated Show resolved Hide resolved

Warchant added 2 commits July 4, 2020 19:55

Fix license, remove unnecessary alloc

ecca3ee

Remove gh actions; use 10/12 nodejs in travis

0d827c2

muromec reviewed Jul 5, 2020

View reviewed changes

src/gost89.ts Outdated Show resolved Hide resolved

src/gost89.ts Outdated Show resolved Hide resolved

src/gost89.ts Show resolved Hide resolved

Return Buffer in mac_out and mac

b59bf86

dependabot bot and others added 12 commits February 14, 2022 02:05

Merge pull request #10 from Warchant/dependabot/npm_and_yarn/minimist…

5748865

…-1.2.8 Bump minimist from 1.2.5 to 1.2.8

Merge pull request #9 from Warchant/dependabot/npm_and_yarn/cacheable…

34573c4

…-request-and-gts--removed Bump cacheable-request and gts

Merge pull request #13 from Warchant/dependabot/npm_and_yarn/ansi-reg…

20b11fa

…ex-5.0.1 Bump ansi-regex from 5.0.0 to 5.0.1

Warchant and others added 8 commits October 22, 2023 22:30

Merge pull request #1 from Warchant/dependabot/npm_and_yarn/ajv-6.12.6

d5fd4fb

Bump ajv from 6.12.2 to 6.12.6

Merge pull request #4 from Warchant/dependabot/npm_and_yarn/minimatch…

e290653

…-3.1.2

Merge pull request #12 from Warchant/dependabot/npm_and_yarn/babel/tr…

a947b7b

…averse-7.23.2

Merge pull request #11 from Warchant/dependabot/npm_and_yarn/lodash-4…

fe97613

….17.21

Merge pull request #7 from Warchant/dependabot/npm_and_yarn/json5-2.2.3

7118980

Merge pull request #6 from Warchant/dependabot/npm_and_yarn/qs-6.5.3

948a287

Merge pull request #5 from Warchant/dependabot/npm_and_yarn/decode-ur…

17481f6

…i-component-0.2.2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate from Javascript to Typescript#3

Migrate from Javascript to Typescript#3
Warchant wants to merge 31 commits intodstucrypt:masterfrom
Warchant:master

Warchant commented Jul 4, 2020 •

edited

Loading

Uh oh!

Warchant commented Jul 4, 2020

Uh oh!

Uh oh!

muromec Jul 4, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Warchant commented Jul 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Warchant commented Jul 16, 2020

Uh oh!

muromec commented Jul 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Warchant commented Jul 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Warchant commented Jul 4, 2020

Uh oh!

Uh oh!

muromec Jul 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Warchant commented Jul 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Warchant commented Jul 16, 2020

Uh oh!

muromec commented Jul 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Warchant commented Jul 4, 2020 •

edited

Loading

muromec Jul 4, 2020 •

edited

Loading