🔒 [security fix] Insecure Temporary File Creation in encode.moon#1
🔒 [security fix] Insecure Temporary File Creation in encode.moon#1dsetareh wants to merge 1 commit into
Conversation
- Replace predictable hardcoded temporary path with unique paths generated by os.tmpname(). - Implement a robust cleanup mechanism using a global tracking table and mpv shutdown event. - Handle Windows-specific os.tmpname() behavior by prepending system temp directories. - Export necessary utility functions and variables for cross-module access. Co-authored-by: dsetareh <15238752+dsetareh@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
dont care |
Acknowledged. |
🎯 What: The vulnerability fixed was the use of a predictable temporary file path (
~/cache_dump.ts) when dumping HLS stream caches.🛡️ Solution:
os.tmpname()to generate unique, non-predictable temporary filenames.get_temp_pathhelper that handles Windows-specific quirks (ensuring absolute paths).temp_files_to_cleanregistry and ashutdownevent handler to ensure all generated temporary files are deleted, even if the script is interrupted or crashes.PR created automatically by Jules for task 10989839207706548942 started by @dsetareh