UpdateServicesServer, UpdateServicesApprovalRule: Fixing Products processing, verbose output#64
UpdateServicesServer, UpdateServicesApprovalRule: Fixing Products processing, verbose output#64MartinVokurek wants to merge 4 commits into
Conversation
|
I think I'll need a bit of advice on how to deal with all the failed checks, as they seem to be mostly unrelated to the changes that I made. Should I ignore them? Or do they need to be fixed first, before my changes can be accepted? |
|
Project likes dead. How can we made progression in it that the pull request are approved? |
|
Is this project abandoned? |
|
No, but I need to be reminded (on slack) or see the notifications. |
|
Curious if this PR will be merged? |
|
@NicolasBn has this been included part of your merged changes? |
|
@TheBlackMini or @luzkenin are you able to rebase this branch and re-submit a PR. |
|
@gaelcolas Indeed. To cover issue #61, I need to update |
|
So, @NicolasBn do I need to do anything? |
|
@TheBlackMini I don't have any time before next week. If you don't want to wait, you can submit your PR :) |
|
I worked on a solution here : Get-UpdateServicesDscProduct I created a function to find all products based on value passed on I 'just' need to use it in |
|
@gaelcolas @NicolasBn Any updates on getting this merged? |
Borgquite
left a comment
Borgquite
left a comment
There was a problem hiding this comment.
Hey,
There are some useful fixes here, but some are already implemented? Can you resubmit and rebase?
| else | ||
| { | ||
| $Languages = $WsusConfiguration.GetEnabledUpdateLanguages() | ||
| $Languages = ($WsusConfiguration.GetEnabledUpdateLanguages()) -join ',' |
There was a problem hiding this comment.
This needs to be
$Languages = [String[]]$WsusConfiguration.GetEnabledUpdateLanguages()
As otherwise it's not returning a string array, but a single string joined by a comma
| Write-Verbose -Message ($script:localizedData.WsusClassifications -f $Classifications) | ||
| Write-Verbose -Message $script:localizedData.GettingWsusProducts | ||
| if ($Products = @($WsusSubscription.GetUpdateCategories().Title)) | ||
| if ($Products = (@($WsusSubscription.GetUpdateCategories().Title) | Sort-Object -Unique)) |
There was a problem hiding this comment.
This change is already in the main branch - you may need to rebase?
| if ($Products = (@($WsusSubscription.GetUpdateCategories().Title) | Sort-Object -Unique)) | ||
| { | ||
| if ($null -eq (Compare-Object -ReferenceObject ($Products | Sort-Object -Unique) -DifferenceObject ` | ||
| if ($null -eq (Compare-Object -ReferenceObject $Products -DifferenceObject ` |
| if ($null -ne $WsusServer) | ||
| { | ||
| Write-Verbose -Message ('Identified WSUS server information: {0}' -f $WsusServer) | ||
| Write-Verbose -Message ('Identified WSUS server information: {0}' -f $WsusServer.Name) |
There was a problem hiding this comment.
This is already in the Main branch - need to rebase?
|
|
||
| ## [Unreleased] | ||
|
|
||
| ### Fixed |
There was a problem hiding this comment.
Need to update CHANGELOG as some changes are already implemented
8 participants
Pull Request (PR) description
UpdateServicesServerandUpdateServicesApprovalRuleUpdateServiceServerUpdateServicesApprovalRuleThis Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is