chore(contributors): evidence-based all-contributors audit (+yodakanohoshi, badge expansion)#620
Conversation
…hoshi, badge expansion) Audit of `.all-contributorsrc` and the README contributor table against actual observable contributions. Every badge change here has explicit PR/issue evidence — no role-based defaults, no self-promotion. ## What changed ### Missing entry added - **@yodakanohoshi** — co-Owner per GOVERNANCE.md, listed in repo collaborators, but was entirely absent from `.all-contributorsrc`. Added with badges reflecting actual contributions: - code: #610 ClickHouse identifier fix (substantial) - doc: #466 i18n marker sync - maintenance: #440 post-merge cleanup, #513 CHANGELOG tidy - ideas: 10 reported issues (#258 staged_upload, #413 drt diff, #414 sync failure alerts, #415 field_mappings, #416 Amplitude, #417 Mixpanel, #418-421 destination requests) - review: PR reviews as Owner (e.g. #613 S3) - projectManagement: co-Owner role per GOVERNANCE.md ### URL fix (source-of-truth sync) - **@Muawiya-contact** — `.all-contributorsrc` still pointed to the old YouTube URL (`https://www.youtube.com/@Coding_Moves`). The README was fixed in #616 but the source-of-truth file wasn't, so the next `all-contributors generate` would have reverted the README change. Synced to the correct portfolio URL (`https://muawiya-contact.github.io/muawiya-portfolio/`). ### Badge expansions (evidence-based) - **@masukai** (code → code, doc, maintenance, ideas, tool, projectManagement, review, mentoring): - doc: connector docs #614, mirror docs #607, ROADMAP, CLAUDE.md, release notes - maintenance: release cuts (#602, #611), CHANGELOG monotonic check - ideas: v0.7.x narrative design, #619 Phase 3 sub-issue, milestone planning - tool: `.claude/commands/drt-release-check.md`, drt-create-sync skill - projectManagement: milestone management (v0.7.x / v0.8 / v0.9 / v1.0) - review: PR #608 (Mixpanel), #610 (ClickHouse), #615 (OTel Phase 2) - mentoring: #619 honest-feedback reply, #584 BigQuery coaching - **@Muawiya-contact** (code → code, doc, infra, maintenance, ideas): - doc: OPEN_CORE.md #456, VERSIONING.md #457 #464 — "writing the rules of this project" contributions that most contributors never touch - infra: all-contributors workflow #436, OTel CI integration - maintenance: #492 orphan shadow cleanup, #478 deprecation warnings - ideas: #616 CI env vuln flag (cross-PR awareness), Phase 3 wireup - **@cian-ps** (code → code, bug, infra): - code preserved: #529 (`drt init` "Next steps"), #574 (Amplitude destination) - bug added: #561 CI mypy mismatch report - infra added: #323 FUNDING.yml + Sponsor badge ### Badge corrections (mis-tagged code → actual contribution type) - **@xtreellaDev** (code → test): #325 was a contract test PR - **@Ai-chan-0411** (code → doc): #313 was a docs-only PR (connector support matrix with auth methods) ### Unchanged (correctly tagged already) @Khush-domadia, @Pawansingh3889, @PFCAaron12, @armorbreak001, @pureqin, @wahajahmed010, @GokulKashyap — all correctly tagged based on their PR history. ## Methodology Followed all-contributors evidence-based principles: - Badges reflect observable contributions, not titles - Every badge has cited PR / issue evidence in this commit message - Owner badges receive the same evidence requirement as anyone else (no "Owner therefore many badges" shortcut) - Order in `.all-contributorsrc` places Owners first (masukai, yodakanohoshi), then by initial contribution chronology README badge count: 12 → 13. README + README.ja contributor tables regenerated to match. [skip changelog] — recognition / metadata only, no behaviour change. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Discovered by scripts/check_contributors.sh (Phase 2, PR #621): - @Photon101 — 9 merged PRs (badges: code, maintenance) - @kiwamizamurai — 2 merged PRs (badges: code, bug) Both qualify as Triage Collaborator candidates under GOVERNANCE.md (5+ PRs OR major contribution end-to-end); Photon101 in particular has been steadily active over the last 30 days. Also re-syncs README.ja.md i18n marker against the new README.md base hash. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Adding 2 more Triage Collaborator candidates surfaced by
@Photon101 in particular cleared the GOVERNANCE.md "5+ merged PRs" line a while ago and slipped past my manual review — exactly the gap the Phase 2 audit script was meant to catch. Filing it here so #620 reflects the actual contributor set on merge. cc @yodakanohoshi — same evidence-based methodology, just two additional rows. |
|
@yodakanohoshi — small ping when you have a window 🙏 This one's docs-only: all-contributors metadata audit (URL drift fixes, badge corrections, +2 missing Triage Collaborators discovered via #621's audit script). Lowest review cost of the four; no code paths touched. No rush — just flagging so it's on your radar. |
|
Thanks for the audit, @masukai! The methodology table — tying every badge to a specific PR/issue as evidence — is genuinely thorough, and it does a great job correcting the under-counting of existing entries that were stuck on I also reviewed my own entry expansion — #610 / #466 / #440 & #513 / issue reports / #613 review all line up, so it checks out. Just one thing to fix before merge 🔴 The README.md badge is still Fix the badge count and I'll approve and merge. |
|
|
||
| <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section --> | ||
| [](#contributors-) | ||
| [](#contributors-) |
There was a problem hiding this comment.
This should be 15, not 13. The PR adds 3 contributors (@yodakanohoshi / @Photon101 / @kiwamizamurai), so 12 → 15. README.ja.md already has all_contributors-15 .
…y table yodakanohoshi caught this in #620 review: README.md's badge still read `all_contributors-13` while its own contributor table lists 15 people and README.ja.md was already correct at 15. The 13 was a stale intermediate value from when this PR added only yodakanohoshi (12 → 13) before @Photon101 / @kiwamizamurai were added (→ 15); README.ja.md got the 15 bump but README.md was missed. Now consistent: badge (both languages) + table (both languages) + .all-contributorsrc all read 15. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Keeps `make check-i18n` clean after the badge correction — the marker was already one commit stale on this branch (recorded 79b6171, base updated at 3776c6c), and the badge fix moved README.md's tip again. Content is identical between the two READMEs; this is just the marker hash. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Fixed — thanks for the careful catch 🙏
Also slipped in a tiny And thanks for self-reviewing your own entry expansion against #610 / #466 / #440 / #513 / #613 — that's exactly the kind of cross-check that keeps an evidence-based audit honest. Ready when you are. |
yodakanohoshi
left a comment
yodakanohoshi
left a comment
There was a problem hiding this comment.
Badge count fixed — README.md and README.ja.md are both on all_contributors-15 now, and the i18n hash marker is resynced so make check-i18n stays clean. CI is green across all 8 checks. The new commit touches only the badge + hash, nothing else.
Evidence-based methodology, the source-of-truth URL sync, and the two contributors caught by #621's audit script all check out. My own entry was reviewed against its cited evidence. Approving — thanks @masukai! 🙌
2 participants
Summary
Evidence-based audit of
.all-contributorsrcand the README contributor table. Every badge change has explicit PR/issue evidence — no role-based defaults, no self-promotion shortcuts.Why
Three issues surfaced during the #531 / #619 conversation with @Muawiya-contact:
.all-contributorsrc..all-contributorsrcentry still pointed to the old YouTube URL. The README was fixed in Add docs/add-muawiya-url. #616, but the source-of-truth wasn't, so the nextall-contributors generatewould have reverted Add docs/add-muawiya-url. #616.code, but several had clear evidence of other contribution types (doc / infra / ideas / maintenance / test / bug).Methodology (evidence table)
Cited evidence per badge change. Owner badges follow the same evidence requirement as anyone else — no "Owner therefore many badges" shortcut.
@yodakanohoshi — NEW entry (co-Owner)
@Muawiya-contact — URL fix + badge expansion (
code→code, doc, infra, maintenance, ideas)Also: URL synced from
https://www.youtube.com/@Coding_Movestohttps://muawiya-contact.github.io/muawiya-portfolio/(the source-of-truth fix #616 was waiting for).@masukai — badge expansion (
code→ 8 badges).claude/commands/drt-release-check.md, drt-create-sync skill, drt-init skill@cian-ps —
code→code, bug, infradrt init"Next steps", #574 Amplitude destination (full destination, substantial)@xtreellaDev — correction
code→test@Ai-chan-0411 — correction
code→docUnchanged (correctly tagged already)
@Khush-domadia, @Pawansingh3889, @PFCAaron12, @armorbreak001, @pureqin, @wahajahmed010, @GokulKashyap — verified against PR history, current tags are accurate.
Not in this PR (deliberately deferred)
make check-contributorsscript (detect README ↔.all-contributorsrcURL drift + missing entries for active contributors) and PR-label → badge auto-suggestion will land as a separate PR so this one stays scoped to recognition-data only.Asking @yodakanohoshi for review
As co-Owner, please sanity-check both your own entry and the @masukai badge expansion — having both Owner entries reviewed by the other Owner is the objectivity safeguard. If anything seems off, flag it.
Test plan
make check-i18n— clean (README + README.ja regenerated in sync)make lint— ruff + mypy clean[skip changelog]— recognition / metadata only, no behaviour or release-note impact.🤖 Generated with Claude Code