Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(codegen): SceneSerializer glm::vec3 Clamp support (#451 slice) #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(codegen): SceneSerializer glm::vec3 Clamp support (#451 slice) #580
Changes from all commits
59c4df56e33100File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Check warning on line 101 in OloEngine/src/OloEngine/Scene/Components.h
Use "=default" instead of the default implementation of this comparison function.
Check warning on line 113 in OloEngine/src/OloEngine/Scene/Components.h
Change this "struct" to a "class" or remove its member functions.
Check warning on line 117 in OloEngine/src/OloEngine/Scene/Components.h
Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container.
Check warning on line 120 in OloEngine/src/OloEngine/Scene/Components.h
Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container.
Check warning on line 123 in OloEngine/src/OloEngine/Scene/Components.h
Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container.
Check failure on line 128 in OloEngine/src/OloEngine/Scene/Components.h
Customize this struct's destructor to participate in resource management.
Check warning on line 128 in OloEngine/src/OloEngine/Scene/Components.h
Don't mix public and private data members.
Check warning on line 159 in OloEngine/src/OloEngine/Scene/Components.h
Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container.
Check warning on line 159 in OloEngine/src/OloEngine/Scene/Components.h
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
Check warning on line 161 in OloEngine/src/OloEngine/Scene/Components.h
Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container.
Check warning on line 165 in OloEngine/src/OloEngine/Scene/Components.h
Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container.
Check warning on line 165 in OloEngine/src/OloEngine/Scene/Components.h
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
Check warning on line 167 in OloEngine/src/OloEngine/Scene/Components.h
Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container.
Check warning on line 171 in OloEngine/src/OloEngine/Scene/Components.h
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
Check warning on line 171 in OloEngine/src/OloEngine/Scene/Components.h
Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container.
Check warning on line 173 in OloEngine/src/OloEngine/Scene/Components.h
Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container.
Check warning on line 212 in OloEngine/src/OloEngine/Scene/Components.h
Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container.
Check warning on line 217 in OloEngine/src/OloEngine/Scene/Components.h
Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container.
Check warning on line 222 in OloEngine/src/OloEngine/Scene/Components.h
Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container.
Check warning on line 1426 in OloEngine/src/OloEngine/Scene/Components.h
Change this "struct" to a "class" or remove its member functions.
Check warning on line 1447 in OloEngine/src/OloEngine/Scene/Components.h
Don't mix public and private data members.
Check warning on line 1458 in OloEngine/src/OloEngine/Scene/Components.h
Split this 292 characters long line (which is greater than 230 authorized).
Check warning on line 1464 in OloEngine/src/OloEngine/Scene/Components.h
Split this 286 characters long line (which is greater than 230 authorized).
Check warning on line 1465 in OloEngine/src/OloEngine/Scene/Components.h
Split this 286 characters long line (which is greater than 230 authorized).
Check warning on line 1466 in OloEngine/src/OloEngine/Scene/Components.h
Split this 283 characters long line (which is greater than 230 authorized).
Check warning on line 1478 in OloEngine/src/OloEngine/Scene/Components.h
Overloaded member functions with same access specifier should be grouped in the interface.
Check warning on line 1489 in OloEngine/src/OloEngine/Scene/Components.h
Overloaded member functions with same access specifier should be grouped in the interface.
Check warning on line 1494 in OloEngine/src/OloEngine/Scene/Components.h
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
Check warning on line 1498 in OloEngine/src/OloEngine/Scene/Components.h
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
Check warning on line 1502 in OloEngine/src/OloEngine/Scene/Components.h
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
Check warning on line 1510 in OloEngine/src/OloEngine/Scene/Components.h
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
Check warning on line 1518 in OloEngine/src/OloEngine/Scene/Components.h
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
Check warning on line 1526 in OloEngine/src/OloEngine/Scene/Components.h
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
Check failure on line 1794 in OloEngine/src/OloEngine/Scene/SceneSerializer.cpp
Do not pass an array as a single pointer. Consider using std::string_view to avoid array to pointer decay.
Check warning on line 1794 in OloEngine/src/OloEngine/Scene/SceneSerializer.cpp
Rewrite the function arguments to make its use less error-prone.
Check warning on line 3789 in OloEngine/src/OloEngine/Scene/SceneSerializer.cpp
Use "std::to_underlying" to cast enums to their underlying type.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.