add support for changes to computed arrays and maps#10
Open
kyleadams-nflx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if the diff includes a map or array that is computed, the parser will fail. This is because it assumes that the only way a map or array could be changed at a top level, is if it gets nulled out. Otherwise any changes would appear in the body of the array or map. So this works:
However if the map or array is set to computed, such that its value is (known after apply), then the format of the plan is similar to the whole map or array being replaced, but doesn't end in "null", so the parsing logic doesn't know what to do.
This PR adds the
(known after apply)as an alternative expected ending to an array or map field. Tests have been included to validate the new behavior.