D11 by vincent-gao · Pull Request #723 · dpc-sdp/tide_core

vincent-gao · 2026-01-13T09:11:14Z

Jira

Problem/Motivation

Fix

Related PRs

Screenshots

TODO

# Conflicts: # composer.dev.json # composer.json

vincent-gao · 2026-01-21T23:39:51Z

config/install/ckeditor_templates.ckeditor_templates.blockquote.yml

 description: 'Blockquote with 2 lines of caption'
 thumb: {  }
-code: "<blockquote class=\"quotation\">\r\n<p>Berios sim destrum facientota nis ex eost aut prae vendis explam aliquis dolorpo rrorem reptaep elenis net.</p>\r\n\r\n<footer><cite><span class=\"quotation__author\">Her Excellency the Honourable Linda Dessau AC</span><br />\r\n<span class=\"quotation__author-title\">Governor of Victoria</span> </cite></footer>\r\n</blockquote>\r\n"
+code:


[NOTE] This needs an update hook.

vincent-gao · 2026-01-21T23:42:04Z

config/install/editor.editor.admin_text.yml

@@ -80,8 +80,9 @@ settings:
        - '<td align class>'
        - '<p class="quotation__quote">'
    ckeditor5_list:


[NOTE] This needs an update hook.

vincent-gao · 2026-01-21T23:44:20Z

config/install/views.view.tide_media_browser.yml

@@ -918,72 +918,6 @@ display:
          multi_type: separator
          separator: ', '
          field_api_classes: false


[NOTE] Investigate the cause of the tide_media_browser failure due to the missing field_secure_file_target_id.

vincent-gao · 2026-01-21T23:44:45Z

config/optional/views.view.media.yml

          multi_type: separator
          separator: ', '
          field_api_classes: false
-        filemime_1:


[NOTE] Investigate the cause of the tide_media_browser failure due to the missing field_secure_file_target_id.

vincent-gao · 2026-01-21T23:45:50Z

scripts/drupal-init-module.sh

 COMPOSER=${COMPOSER:-composer.build.json}
 APP=${APP:-/app}
 WEBROOT=${WEBROOT:-docroot}
-TEST_PACKAGE_NAME=${TEST_PACKAGE_NAME:-tide_test}


[NOTE] check if this part needs to removed from automation

vincent-gao · 2026-01-21T23:46:36Z

composer.dev.json

        "drupal/core-composer-scaffold": "^11.0",
-        "drupal/core": "10.5.2",
-        "drupal/core-recommended": "10.5.2",
+        "drupal/core": "11.x",


[NOTE] This needs to be changed to 11.3.x

vincent-gao · 2026-01-21T23:48:32Z

composer.dev.json

        "drupal": {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
-            "exclude": ["drupal/token_conditions", "drupal/ckeditor_templates", "drupal/create_menus_permission"]


[NOTE] check why do we need the customised "drupal/token_conditions", "drupal/ckeditor_templates", "drupal/create_menus_permission"

vincent-gao · 2026-01-21T23:49:04Z

docker-compose.yml


  mariadb:
-    image: "ghcr.io/dpc-sdp/bay/mariadb:${BAY_IMAGE_VERSION:-6.x}"
+    image: "uselagoon/mariadb-10.6-drupal:latest"


[NOTE] D11 needs mariadb-10.6+

vincent-gao · 2026-01-21T23:49:31Z

docker-compose.yml


  redis:
-    image: amazeeio/redis
+    image: uselagoon/redis-5:latest


[NOTE] why did I set it to uselagoon/redis-5:latest ???

vincent-gao · 2026-01-21T23:50:08Z

tide_core.info.yml

  - entity_reference_revisions:entity_reference_revisions
  - quick_node_clone:quick_node_clone
+  - ckeditor5_embedded_content:ckeditor5_embedded_content
+  - embedded_content:embedded_content


[NOTE] we have to migrate from ckeditor5_embedded_content to embedded_content

vincent-gao · 2026-01-21T23:51:52Z

composer.json

    "extra": {
        "patches": {
            "drupal/admin_audit_trail": {
-                "Add an option to allow logging in CLI - https://www.drupal.org/project/admin_audit_trail/issues/3263615#comment-16412890": "https://www.drupal.org/files/issues/2026-01-15/3263615-admin_audit_trail-option-for-cli-10.patch"


[NOTE] check patches.

vincent-gao · 2026-01-21T23:52:25Z

composer.json

+            "drupal/core-composer-scaffold": true
        },
        "audit": {
-          "ignore": {


[NOTE] use "block-insecure": false

vincent-gao · 2026-01-22T04:48:21Z

config/install/editor.editor.rich_text.yml

  scheme: public
  directory: inline-images
-  max_size: ''
+  max_size: '10MB'


[NOTE] it needs an update hook.

vincent-gao · 2026-01-22T04:48:48Z

config/install/editor.editor.rich_text.yml

    ckeditor5_list:
-      reversed: true
-      startIndex: true
+      properties:


[NOTE] It needs an update hook.

vincent-gao · 2026-01-22T04:49:26Z

config/install/filter.format.rich_text.yml

 status: true
 dependencies:
  module:
-    - ckeditor5_embedded_content


[NOTE] this needs to move to tide_ckeditor module

vincent-gao added 4 commits January 19, 2026 18:45

D11

ae9f8e0

# Conflicts: # composer.dev.json # composer.json

update custom modules to work with D11

ca5455b

update

4da92fb

update ckeditor_templates

fec5ce6

vincent-gao force-pushed the D11_upgrade branch 2 times, most recently from 91b6d36 to 8938527 Compare January 21, 2026 05:35

remove tide_test module from composer.json

b4f1f77

vincent-gao force-pushed the D11_upgrade branch from 8938527 to b4f1f77 Compare January 21, 2026 05:54

fixed media widget

18716eb

vincent-gao added the DO NOT REVIEW label Jan 21, 2026

vincent-gao commented Jan 21, 2026

View reviewed changes

update

485e16e

vincent-gao commented Jan 22, 2026

View reviewed changes

add patches back

f550cba

Conversation

vincent-gao commented Jan 13, 2026

Jira

Problem/Motivation

Fix

Related PRs

Screenshots

TODO

Uh oh!

vincent-gao Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vincent-gao Jan 21, 2026 •

edited

Loading