chore: update spotless-plugin to 3.0.0 and palantir-java-format to 2.74.0#149
Conversation
…74.0 Current configuration yields `NoSuchMethodError` upon compilation when using java 25, which is now fixed in `palantir-java-format:2.71.0`: palantir/palantir-java-format#1305 That only change would be sufficient, but I updated the palantir version to `2.74.0` and also the spotless plugin to `3.0.0` to comply with this change in the original repo: feature-tracker@1e2fca6 Also fixes readme that still mentioned java 21 as prerequisite, when in fact it is now java 24.
| <name>feature-service</name> | ||
| <description>feature-service</description> | ||
| <properties> | ||
| <java.version>24</java.version> |
There was a problem hiding this comment.
From my perspective, we should keep using Java 24 for this project.
We should double-check how the Java version is currently determined by the framework.
There was a problem hiding this comment.
This property means that minumum java24 is required, but java25 (which is now latest) is also fine, as they're backward compatible.
The problem is, project doesn't compile under java25 due to a bug in the spotless-plugin/palantir-format. Upgrading those simply allows the project to run on java25, not forcing this upgrade, but allowing it.
Original repo already has this change added as well (see PR description)
|
To make sure, I have tested this change under java 24.0.2 as well: I had to install the custom java 24 build from the archive at https://jdk.java.net/archive for this, which is not recommended generally. |
|
Lets merge, then new datapoint will not have issue with java 25 |
…74.0 - merge pull request #149 from dpaia/update-spotless-plugin-version
3 participants
Current configuration yields
NoSuchMethodErrorupon compilation when using java 25, which is now fixed inpalantir-java-format:2.71.0: palantir/palantir-java-format#1305That only change would be sufficient, but I updated the palantir version to
2.74.0and also the spotless plugin to3.0.0to comply with this change in the original repo: feature-tracker@1e2fca6Also fixes readme that still mentioned java 21 as prerequisite, when in fact it is now java 24.