This repository was archived by the owner on Apr 7, 2023. It is now read-only.
Fix download of local files#3
Open
Flink wants to merge 2 commits into
Open
Conversation
Download of local files was broken as #download! was explicitly called on the uploader. Use of #cache_stored_file! should work for any backend. Signature of CarrierWave::SecureFile::Downloader.call() has changed. It now accepts only one argument: an uploader instance.
Owner
|
hey @Flink - sorry i haven't noticed this pull request sooner. i'm going to hold on this pull request for the time being - i want to do a little digging into carrierwave and be able to provide some backwards compatibility, and, of course, test this solution out. the project i built this gem for i'm no longer maintaining, so i'm not spending a lot of time on this ATM - i'll probably look at this at the start of the year. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download of local files was broken as
#download!was explicitly called on the uploader. Use of#cache_stored_file!should work for any backend.Signature of
CarrierWave::SecureFile::Downloader.call()has changed. It now accepts only one argument: an uploader instance.