[Snyk] Security upgrade python from 3.13.7-slim to 3.14.1-slim #11
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174592 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174592 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174602 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174605 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174605
Summary of ChangesHello @doublegate, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, focuses on enhancing the security posture of the project by updating the Docker base image for the Python service. The primary goal is to mitigate known vulnerabilities by moving to a more recent and secure Python slim image, ensuring the application benefits from the latest security fixes and a reduced attack surface. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
services/arms/coder/Dockerfile
Outdated
| # syntax=docker/dockerfile:1 | ||
| # Coder Arm Dockerfile - Multi-stage build for Python service | ||
| FROM python:3.13.7-slim as builder | ||
| FROM python:3.14.1-slim as builder |
There was a problem hiding this comment.
Builder/runtime bases are now python:3.14.1-slim, but the image still copies dependencies from /usr/local/lib/python3.13/site-packages (see line 41). With Python 3.14 the 3.13 directory no longer exists or is not on sys.path, so the Docker build will either fail at the COPY step or produce a runtime image missing all installed packages whenever this Dockerfile is built.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR attempts to upgrade the Python base Docker image from 3.13.7-slim to 3.14.1-slim to address security vulnerabilities in OpenSSL dependencies. However, there is a critical issue: Python 3.14.1 does not exist as of January 2025, as Python 3.14 has not been released yet. This will cause the Docker build to fail.
Key Changes:
- Updated Python base image in builder stage from 3.13.7-slim to 3.14.1-slim
- Updated Python base image in runtime stage from 3.13.7-slim to 3.14.1-slim
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the Python base image to 3.14.1-slim to address security vulnerabilities. This is a good security practice.
However, the change as-is will break the Docker build. I've left a comment on the Dockerfile explaining that a hardcoded path for Python's site-packages directory needs to be updated to match the new Python version. Without this fix, the build will fail.
I've also noticed that several other services in this repository use the same Python version and will likely need a similar upgrade. Applying this change consistently across all services is recommended.
To make future upgrades easier and less error-prone, I suggest using a build argument (ARG) for the Python version in your Dockerfiles. This would centralize the version number and ensure all paths are updated correctly when the version changes. For example:
ARG PYTHON_VERSION=3.14
ARG PYTHON_FULL_VERSION=3.14.1-slim
FROM python:${PYTHON_FULL_VERSION} as builder
...
COPY --from=builder /usr/local/lib/python${PYTHON_VERSION}/site-packages /usr/local/lib/python${PYTHON_VERSION}/site-packagesThis would improve the maintainability of your Dockerfiles.
services/arms/coder/Dockerfile
Outdated
|
|
||
| # Runtime stage | ||
| FROM python:3.13.7-slim | ||
| FROM python:3.14.1-slim |
There was a problem hiding this comment.
While upgrading the Python base image is correct for security, this change will cause the Docker build to fail. The COPY command on line 41 hardcodes the Python version 3.13 for the site-packages path. Since the builder stage now uses Python 3.14, the packages are installed in /usr/local/lib/python3.14/site-packages, and the old path doesn't exist.
This path needs to be updated to python3.14 to match this new base image.
Suggested change for line 41:
- COPY --from=builder /usr/local/lib/python3.13/site-packages /usr/local/lib/python3.13/site-packages
+ COPY --from=builder /usr/local/lib/python3.14/site-packages /usr/local/lib/python3.14/site-packages
Snyk has created this PR to fix 3 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):
services/arms/coder/DockerfileWe recommend upgrading to
python:3.14.1-slim, as this image has only 23 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.Vulnerabilities that will be fixed with an upgrade:
SNYK-DEBIAN13-OPENSSL-13174592
SNYK-DEBIAN13-OPENSSL-13174592
SNYK-DEBIAN13-OPENSSL-13174602
SNYK-DEBIAN13-OPENSSL-13174605
SNYK-DEBIAN13-OPENSSL-13174605
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.