-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade pyasn1 from 0.4.8 to 0.6.2 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-PYASN1-15032639
Summary of ChangesHello @doublegate, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security update for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to upgrade pyasn1 to version 0.6.2 to address a security vulnerability. However, this upgrade introduces a critical dependency conflict with the python-jose package, which will cause the application's dependency installation to fail. The python-jose package requires a version of pyasn1 that is incompatible with the proposed secure version, and there is no newer version of python-jose available that resolves this conflict. Therefore, this pull request cannot be merged in its current state as it would break the build.
| zipp>=3.19.1 # not directly required, pinned by Snyk to avoid a vulnerability | ||
| dnspython>=2.6.1 # not directly required, pinned by Snyk to avoid a vulnerability | ||
| numpy>=1.22.0 # not directly required, pinned by Snyk to avoid a vulnerability | ||
| pyasn1>=0.6.2 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade of pyasn1 to version >=0.6.2 creates a critical dependency conflict that will break the application build.
The python-jose==3.4.0 package, specified on line 44, requires pyasn1<0.5.0. This new requirement for pyasn1>=0.6.2 is mutually exclusive with the existing dependency, which will cause pip install to fail with a dependency resolution error.
The security vulnerability in pyasn1 requires an upgrade to version 0.5.0 or newer. Since the latest version of python-jose (3.4.0) does not support this, a direct upgrade of pyasn1 is not possible while keeping python-jose.
This PR cannot be merged as it will break the dependency installation. A different approach is needed, such as finding an alternative to python-jose or waiting for an updated version that supports a secure pyasn1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the API’s pip dependencies to address a Snyk-reported vulnerability by explicitly pinning a safer pyasn1 version.
Changes:
- Add
pyasn1>=0.6.2toapi/requirements.txtas a Snyk vulnerability pin.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
api/requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling