Removed sync call in saving llm cost#170
Open
NickLucche wants to merge 1 commit intodotneet:mainfrom
Open
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @dotneet on Vercel. @dotneet first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey. thanks for your work maintaining this repo!
More like a question, but since the change is so small I thought it'd be faster to just make a PR.
Is there a reason why the llm cost indexing should be synchronous?
I didn't really need that feature so bad on my own use case, and it bothered me a little bit to have that await when serving responses.
Feel free to close this if the await is actually needed to have client synchronized :D