Skip to content

fix(books): don't bump updated_at when reordering the read queue#49

Merged
dotMavriQ merged 1 commit into
mainfrom
fix/read-queue-timestamps
Jun 5, 2026
Merged

fix(books): don't bump updated_at when reordering the read queue#49
dotMavriQ merged 1 commit into
mainfrom
fix/read-queue-timestamps

Conversation

@dotMavriQ

Copy link
Copy Markdown
Owner

Problem

Queue position is organizational, not content — but the mass increment/decrement and per-book updates used for queue ordering all stamped updated_at. So marking a book read (which auto-removes it from the queue and renumbers the rest) made every shifted book jump to the top of the default Recently Updated sort on /books.

Fix

Wrap all queue-position mutations in Book::withoutTimestamps(). Genuine status/date/rating changes still bump updated_at as before. Adds a regression test covering reorder, mark-read, and remove-from-queue paths.

Rescued from the feat/teal-2026-theme branch where it was authored alongside unrelated UI work — landed here on its own so it isn't blocked on the rebrand.

Verification

  • composer stan[OK] No errors (level max)
  • composer lint (Pint) → pass
  • php artisan test94 passed (incl. 3 new BookQueueTimestampTest cases)

🤖 Generated with Claude Code

Queue position is organizational, not content. The mass increment/decrement
and per-book updates used for queue ordering all stamped updated_at, so
marking a book read (which auto-removes it from the queue and renumbers the
rest) made every shifted book jump to the top of the default Recently Updated
sort on /books. Wrap all queue mutations in Book::withoutTimestamps(); genuine
status/date/rating changes still bump updated_at. Adds a regression test.
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@dotMavriQ, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 46 minutes and 20 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: f57e6790-7e5a-420a-884d-0e230ae5fcfa

📥 Commits

Reviewing files that changed from the base of the PR and between dfa2962 and ff417fc.

📒 Files selected for processing (4)
  • app/Livewire/Books/BookIndex.php
  • app/Livewire/Books/BookShow.php
  • app/Livewire/Books/ReadQueue.php
  • tests/Feature/BookQueueTimestampTest.php

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key: "tools"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/read-queue-timestamps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dotMavriQ dotMavriQ merged commit e8f83c0 into main Jun 5, 2026
4 of 5 checks passed
@dotMavriQ dotMavriQ deleted the fix/read-queue-timestamps branch June 5, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant