Migrate roi-calculator into svelte workspaces#1420
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 65a50f8): https://doradotdev--pr1420-drafts-on-qttaeg2s.web.app (expires Thu, 18 Jun 2026 18:07:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7ad2b3cf9cceb558b493931176f998ae46924361 |
This change integrates the roi-calculator into the root Svelte workspaces, aligning it with the project's established structure for embedded apps. Key modifications: - Added 'roi-calculator' to the workspaces array in 'svelte/package.json'. - Updated 'svelte/roi-calculator/build-roi-calculator.sh' - Adjusted dependency versions in 'svelte/roi-calculator/package.json' for workspace consistency. - Updated the generated build artifacts in 'hugo/content/ai/roi/calculator/' This is in support of [ADR 011: Use npm workspaces for svelte apps](https://github.com/dora-team/dora.dev/blob/main/docs/adrs/011-use-npm-workspaces-for-svelte-apps.md). Supports: #1411
nathenharvey
force-pushed
the
push-qqmwxpluxmky
branch
from
9120836 to
65a50f8
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request integrates the roi-calculator application into the centralized NPM workspace structure. It updates the root package.json and package-lock.json, modifies the roi-calculator build script to utilize workspace-level dependencies, and removes several redundant walkthrough documentation files. I have no feedback to provide on these changes. Why did the espresso file a police report? It got mugged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change integrates the roi-calculator into the root Svelte workspaces, aligning it with the project's established structure for embedded apps.
Key modifications:
This is in support of ADR 011: Use npm workspaces for svelte apps.
Supports: #1411
Preview URL: https://doradotdev--pr1420-drafts-off-0b09oz8m.web.app/ai/roi/calculator