feat: add configurable line width, align LineStyle with MarkerStyle#18
Open
zao111222333 wants to merge 2 commits intodonkeyteethUX:mainfrom
Open
feat: add configurable line width, align LineStyle with MarkerStyle#18zao111222333 wants to merge 2 commits intodonkeyteethUX:mainfrom
LineStyle with MarkerStyle#18zao111222333 wants to merge 2 commits intodonkeyteethUX:mainfrom
Conversation
Contributor
Author
|
I discovered this while working on a local This change replaces the previous hard-edged polyline-strip approach with a screen-space analytic AA path:
The fragment shader then computes stroke coverage analytically:
let distance_to_stroke_px = length(vec2<f32>(cap_dx_px, in.local_y_px));
let edge_alpha = clamp(in.half_width_px + 0.5 - distance_to_stroke_px, 0.0, 1.0); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows the same design direction as
MarkerStyleand refactorsLineStyleinto a styling struct that supports both line type and width.Previously, line styling was focused on pattern selection only. With this change,
LineStylebecomes a more complete and extensible API for series lines and reference lines, making line configuration more consistent with the existing marker styling model.Key changes:
LineStylestruct that stores both width and line typeOverall, this makes line styling match the
MarkerStyleapproach more closely and provides a clearer foundation for future styling extensions.