Skip to content

Added additional testing for TIMESTAMP#2413

Merged
Hydrocharged merged 1 commit intomainfrom
daylon/time-tests
Mar 5, 2026
Merged

Added additional testing for TIMESTAMP#2413
Hydrocharged merged 1 commit intomainfrom
daylon/time-tests

Conversation

@Hydrocharged
Copy link
Collaborator

This adds testing for TIMESTAMP and TIMESTAMPTZ, which were missing. This also adds a step in CI that changes the locale to the west coast since we already had such assumptions in other tests (that were eventually changed), and there's no other way to test timezones otherwise.

@Hydrocharged Hydrocharged requested a review from fulghum March 3, 2026 09:27
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Main PR
covering_index_scan_postgres 589.63/s 587.79/s -0.4%
index_join_postgres 124.34/s 124.36/s 0.0%
index_join_scan_postgres 182.98/s 181.34/s -0.9%
index_scan_postgres 11.15/s 11.16/s 0.0%
oltp_point_select 2401.18/s 2392.94/s -0.4%
oltp_read_only 1713.05/s 1716.75/s +0.2%
select_random_points 111.36/s 111.96/s +0.5%
select_random_ranges 447.10/s 448.94/s +0.4%
table_scan_postgres 10.83/s 10.88/s +0.4%
types_table_scan_postgres 4.99/s 5.05/s +1.2%

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Main PR
Total 42090 42090
Successful 17651 17651
Failures 24439 24439
Partial Successes1 5575 5575
Main PR
Successful 41.9363% 41.9363%
Failures 58.0637% 58.0637%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hydrocharged Hydrocharged merged commit 2dc22f3 into main Mar 5, 2026
17 checks passed
@Hydrocharged Hydrocharged deleted the daylon/time-tests branch March 5, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants