ci(docker): pre-install scarb 2.13.1 in the dev image#558
Merged
Conversation
The Piltover submodule (`cartridge-gg/piltover#feat/tee-persistent`) pins `scarb 2.13.1` in its `.tool-versions`. With only 2.8.2 / 2.11.4 / 2.12.2 baked into `ghcr.io/dojoengine/katana-dev:latest`, `make contracts` falls into the runtime install path for 2.13.1 — which OOMs the container's overlay disk. asdf's scarb plugin reports "installation was successful!" even though every file copy fails with "No space left on device", so asdf later prints "No version is set" when scarb is invoked from the piltover dir, and `make contracts` fails. Pre-installing 2.13.1 at image-build time skips the runtime install, so no disk pressure at CI time. Image grows by ~150-300MB. The push to `main` triggers `.github/workflows/build-and-push-docker.yml` to rebuild and re-tag `:latest`; downstream PRs that hit the same wall get unblocked once the new image is published. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-installs
scarb 2.13.1inghcr.io/dojoengine/katana-dev:latestso the Piltover submodule build doesn't fall into a runtime install that OOMs the container's overlay disk.Why
The Piltover submodule (
cartridge-gg/piltover#feat/tee-persistent) pinsscarb 2.13.1in its.tool-versions. The dev image only bakes in2.8.2 / 2.11.4 / 2.12.2, somake install-scarbfalls into the runtime install path for2.13.1. The asdf-scarb plugin lies — every file copy fails with "No space left on device" but the script still prints "installation was successful!". Then whencd piltover && asdf exec scarb buildruns, asdf can't find a realscarbbinary, printsNo version is set for command scarb, andmake contractsfails.Repro from PR #556's most recent CI run:
The Makefile already calls this out (lines 51-52):
Fix
Add `asdf install scarb 2.13.1` to the existing `RUN asdf plugin add scarb && ...` block in `.github/Dockerfile`. Image grows by ~150-300MB; CI runtime install path for 2.13.1 becomes a cache hit (no disk pressure).
Trigger
This push touches `.github/Dockerfile`, so on merge `.github/workflows/build-and-push-docker.yml` rebuilds and re-tags `ghcr.io/dojoengine/katana-dev:latest`. PR #556 (the trigger for this fix) and any other branch that pulls in piltover submodule's new pin will go green once the new image is published.
🤖 Generated with Claude Code