ci: bump dojo-integration-test dojo ref #540
Merged
Merged
Conversation
d0bc32c to
d047cea
Compare
dojo-integration-test dojo ref
b3dc223 to
295caea
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
==========================================
- Coverage 73.32% 66.82% -6.51%
==========================================
Files 209 309 +100
Lines 23132 42985 +19853
==========================================
+ Hits 16961 28723 +11762
- Misses 6171 14262 +8091 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Updates the pinned dojoengine/dojo revision used by dojo-integration-test from v1.7.0-alpha.2 to a6c6047d5e038b83041e06ecfb704ab390981140 so the integration test runs against the current tip of dojo's main branch, which includes dojoengine/dojo#3402. Also bumps scarb from dev-2025-09-05 to 2.13.1 to match the cairo/starknet 2.13 pins in examples/spawn-and-move/Scarb.toml, switches the project build step from sozo build to scarb build, clones Dojo into /tmp/dojo instead of inside \$GITHUB_WORKSPACE so proc-macro resolution during scarb build doesn't collide with Katana's root Cargo.toml workspace, builds sozo from the cloned Dojo source so migrate runs with the sozo matching the revision under test instead of a stale asdf-installed release, and starts Katana with --dev --dev.no-fee so sozo migrate transactions aren't rejected by the mempool. The no-fee flag is needed because Katana's genesis block header is initialized with GasPrices::MIN (1 wei) while the live gas oracle used by mempool validation returns 20 gwei, and sozo (via starknet-rs) estimates fees against BlockTag::Latest which points to genesis right after startup, so the estimated max L1 gas price ends up at 1 wei and gets rejected against the oracle's 20 gwei floor. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
295caea to
85468db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the pinned dojoengine/dojo revision used by dojo-integration-test from v1.7.0-alpha.2 to a6c6047d5e038b83041e06ecfb704ab390981140 so the integration test runs against the current tip of dojo's main branch, which includes dojoengine/dojo#3402. Also bumps scarb from dev-2025-09-05 to 2.13.1 to match the cairo/starknet 2.13 pins in examples/spawn-and-move/Scarb.toml, switches the project build step from sozo build to scarb build, clones Dojo into /tmp/dojo instead of inside $GITHUB_WORKSPACE so proc-macro resolution during scarb build doesn't collide with Katana's root Cargo.toml workspace, builds sozo from the cloned Dojo source so migrate runs with the sozo matching the revision under test instead of a stale asdf-installed release, and starts Katana with
--dev --dev.no-feeso sozo migrate transactions aren't rejected by the mempool. The no-fee flag is needed because Katana's genesis block header is initialized withGasPrices::MIN(1 wei) while the live gas oracle used by mempool validation returns 20 gwei, and sozo (via starknet-rs) estimates fees againstBlockTag::Latestwhich points to genesis right after startup, so the estimated max L1 gas price ends up at 1 wei and gets rejected against the oracle's 20 gwei floor.