Skip to content

fix(constants): correct typo in BIGNUMBERISH_IMPORT constant name #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glihm merged 2 commits into from
Sep 9, 2025
+3 −3
Merged

fix(constants): correct typo in BIGNUMBERISH_IMPORT constant name #3281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c69a076
Update constants.rs
VolodymyrBg Jul 13, 2025
6c657f1
Update interface.rs
VolodymyrBg Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/dojo/bindgen/src/plugins/typescript/generator/constants.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ pub const JS_BOOLEAN: &str = "boolean";
pub const JS_STRING: &str = "string";
pub const JS_BIGNUMBERISH: &str = "BigNumberish";

pub(crate) const BIGNUMNERISH_IMPORT: &str = "import { BigNumberish } from 'starknet';\n";
pub(crate) const BIGNUMBERISH_IMPORT: &str = "import { BigNumberish } from 'starknet';\n";
Comment thread
coderabbitai[bot] marked this conversation as resolved.
pub(crate) const CAIRO_OPTION_IMPORT: &str = "import { CairoOption } from 'starknet';\n";
pub(crate) const CAIRO_ENUM_IMPORT: &str = "import { CairoCustomEnum } from 'starknet';\n";
pub(crate) const CAIRO_OPTION_TYPE_PATH: &str = "core::option::Option";
Expand Down
4 changes: 2 additions & 2 deletions crates/dojo/bindgen/src/plugins/typescript/generator/interface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use cainome::parser::tokens::{Composite, CompositeType, Token};

use super::constants::{BIGNUMNERISH_IMPORT, CAIRO_OPTION_IMPORT, SN_IMPORT_SEARCH};
use super::constants::{BIGNUMBERISH_IMPORT, CAIRO_OPTION_IMPORT, SN_IMPORT_SEARCH};
use super::{token_is_option, JsPrimitiveType};
use crate::error::BindgenResult;
use crate::plugins::typescript::generator::constants::CAIRO_OPTION_TOKEN;
Expand All @@ -11,7 +11,7 @@ impl TsInterfaceGenerator {
fn check_import(&self, token: &Composite, buffer: &mut Buffer) {
// only search for end part of the import, as we append the other imports afterward
if !buffer.has("BigNumberish } from 'starknet';") {
buffer.push(BIGNUMNERISH_IMPORT.to_owned());
buffer.push(BIGNUMBERISH_IMPORT.to_owned());
}

// type is Option, need to import CairoOption
Expand Down
Loading