Skip to content

Conversation

@job13er
Copy link

@job13er job13er commented Apr 21, 2022

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

Security

  • Update yarn.lock and bump mkdirp to resolve some dependabot warnings

@job13er
Copy link
Author

job13er commented Apr 21, 2022

I did see the following in the console when the tests were run:

["@babel/plugin-proposal-private-property-in-object", { "loose": false }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "true" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-methods since the "loose" mode option was set to "false" for @babel/plugin-proposal-private-property-in-object.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-methods", { "loose": false }]
to the "plugins" section of your Babel config.

I don't know if that was already there or not though.

@sandersky
Copy link
Member

I did see the following in the console when the tests were run:


["@babel/plugin-proposal-private-property-in-object", { "loose": false }]

to the "plugins" section of your Babel config.

Though the "loose" option was set to "true" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-methods since the "loose" mode option was set to "false" for @babel/plugin-proposal-private-property-in-object.

The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding

	["@babel/plugin-proposal-private-methods", { "loose": false }]

to the "plugins" section of your Babel config.

I don't know if that was already there or not though.

I've seen that in the past but I don't recall if that was this project or another one. Shouldn't be a blocker though.

@job13er
Copy link
Author

job13er commented Apr 21, 2022

seems like travis didn't get the hint to run the tests. Gonna try closing and re-opening

@job13er job13er closed this Apr 21, 2022
@job13er job13er reopened this Apr 21, 2022
@job13er
Copy link
Author

job13er commented Apr 21, 2022

@sandersky It looks like maybe this project is still trying to build on travis-ci.org when that doesn't build anymore and it needs to switch to travis-ci.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants