Skip to content

Add a way to fetch the original attribute payload when handling converted models#22

Draft
chris-doehring wants to merge 2 commits into
mainfrom
feature/model-with-plain-attributes
Draft

Add a way to fetch the original attribute payload when handling converted models#22
chris-doehring wants to merge 2 commits into
mainfrom
feature/model-with-plain-attributes

Conversation

@chris-doehring
Copy link
Copy Markdown
Contributor

This pull request adds an optional Dogado\JsonApi\Support\Model\PlainAttributesInterface that can be implemented for models, so that one is able to fetch the original attribute payload. This will solve #21.

@chris-doehring chris-doehring added the enhancement New feature or request label Mar 29, 2022
@chris-doehring chris-doehring self-assigned this Mar 29, 2022
@chris-doehring chris-doehring changed the title Add a way to fetch the original attributes payload when handling converted models Add a way to fetch the original attribute payload when handling converted models Mar 29, 2022
@chris-doehring chris-doehring marked this pull request as ready for review March 29, 2022 19:59
Copy link
Copy Markdown
Member

@darthsoup darthsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chris-doehring
Copy link
Copy Markdown
Contributor Author

Whoops, I forgot to add the docs for this change 😮 They will follow shortly.

@chris-doehring
Copy link
Copy Markdown
Contributor Author

Besides missing documentation, this PR needs some further investigation if the feature is really compatible to every aspect of this package.

@chris-doehring chris-doehring marked this pull request as draft October 16, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants